mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Re: Review Request 67413: Added `PYTHON_3` and `PYTHON_3_VERSION` variables in `configure.ac`.
Date Tue, 12 Jun 2018 13:46:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67413/
-----------------------------------------------------------

(Updated June 12, 2018, 1:46 p.m.)


Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, and Kevin Klues.


Changes
-------

Removed `PYTHON_2` and `PYTHON_2_VERSION` to continue using `PYTHON` and `PYTHON_VERSION`
in order to not break `ax_python_devel.m4`.


Summary (updated)
-----------------

Added `PYTHON_3` and `PYTHON_3_VERSION` variables in `configure.ac`.


Bugs: MESOS-8955
    https://issues.apache.org/jira/browse/MESOS-8955


Repository: mesos


Description (updated)
-------

These variables will soon be used to build the CLI.
The goal is to have a clear situation regarding which
version of python is used to build each part of our codebase.


Diffs (updated)
-----

  configure.ac f5a9d5bded40d2af6df7fe872395b076cbd37123 


Diff: https://reviews.apache.org/r/67413/diff/3/

Changes: https://reviews.apache.org/r/67413/diff/2-3/


Testing
-------

I added two lines after the new code:

```
AC_MSG_NOTICE([$PYTHON_2])
AC_MSG_NOTICE([$PYTHON_3])
```

My machine runs Python 2 when using `python` but `python3` is available. The result of `configure`
was:
```
configure: /usr/bin/python
configure: python3
```


Thanks,

Armand Grillet


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message