mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 67496: Ported `EnvTest.EraseEnv` to Windows, with added comments.
Date Mon, 11 Jun 2018 22:29:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67496/
-----------------------------------------------------------

(Updated June 11, 2018, 3:29 p.m.)


Review request for mesos, James Peach and Radhika Jandhyala.


Repository: mesos


Description
-------

The difference between `os::unsetenv` and `os::eraseenv` is important,
but subtle. Now the reason for the existence of `os::eraseenv` is
documented in comments.


Diffs (updated)
-----

  3rdparty/stout/include/stout/posix/os.hpp f898f07515bcc663fea1eef52497feb518d4ca53 
  3rdparty/stout/include/stout/windows/os.hpp 3a728f8cb699c1a4a0bbbf1ecb44f9d33b60e4e3 
  3rdparty/stout/tests/os/env_tests.cpp b5b124dc6316e661af6dd90335ade5283c26d9f2 


Diff: https://reviews.apache.org/r/67496/diff/2/

Changes: https://reviews.apache.org/r/67496/diff/1-2/


Testing
-------

stout-tests on Windows


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message