mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Re: Review Request 67413: Added `PYTHON_2` and `PYTHON_3` environment variables in `configure.ac`.
Date Thu, 07 Jun 2018 14:03:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67413/
-----------------------------------------------------------

(Updated June 7, 2018, 2:03 p.m.)


Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, and Kevin Klues.


Changes
-------

Updated diff as CLI is still using Python 2.


Bugs: MESOS-8955
    https://issues.apache.org/jira/browse/MESOS-8955


Repository: mesos


Description
-------

These variables will soon be used to build the Python bindings and
the CLI. The goal is to have a clear situation regarding which
version of python is used to build each part of our codebase.


Diffs (updated)
-----

  configure.ac f5a9d5bded40d2af6df7fe872395b076cbd37123 


Diff: https://reviews.apache.org/r/67413/diff/2/

Changes: https://reviews.apache.org/r/67413/diff/1-2/


Testing
-------

I added two lines after the new code:

```
AC_MSG_NOTICE([$PYTHON_2])
AC_MSG_NOTICE([$PYTHON_3])
```

My machine runs Python 2 when using `python` but `python3` is available. The result of `configure`
was:
```
configure: /usr/bin/python
configure: python3
```


Thanks,

Armand Grillet


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message