mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <akash-gu...@hotmail.com>
Subject Review Request 67455: Windows: Fixed incorrect return code for `os:kill`.
Date Tue, 05 Jun 2018 20:34:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67455/
-----------------------------------------------------------

Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.


Bugs: MESOS-8666
    https://issues.apache.org/jira/browse/MESOS-8666


Repository: mesos


Description
-------

`os::kill` was returning the opposite error code than expected. It
was returning `KILL_FAIL` on success and `KILL_PASS` on error.


Diffs
-----

  3rdparty/stout/include/stout/os/windows/kill.hpp bdb83510b7f0529d41f8e895451a941dc22d21bb



Diff: https://reviews.apache.org/r/67455/diff/1/


Testing
-------


Thanks,

Akash Gupta


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message