mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Clement Michaud <clement.michau...@gmail.com>
Subject Re: Review Request 67425: [WIP] Implement a JWK Set parser converting JWKs into RSA keys.
Date Mon, 04 Jun 2018 21:56:26 GMT


> On juin 4, 2018, 2:04 après-midi, Alexander Rojas wrote:
> > Before going into detail with this, last patchset we forgot to add certain files
to the install target wich ended up breaking tarball generation. Mostly a failure of your
reviewers (myself included). Since you are adding new files, could you please make sure it
works with `make distcheck` and also make sure of updating the `cmake` build (that should
be a rule of thumb whenever one modifies the `Makefile.am`).

Yes, sure. I did not know I had to run those commands and did not get any failure when not
doing so. I will make sure to run them from now on. Sorry for that.
It would be good to add it in the test workflow though, don't you think?

Thanks.
Clément.


- Clement


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67425/#review204254
-----------------------------------------------------------


On juin 4, 2018, 1:27 après-midi, Clement Michaud wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67425/
> -----------------------------------------------------------
> 
> (Updated juin 4, 2018, 1:27 après-midi)
> 
> 
> Review request for mesos and Alexander Rojas.
> 
> 
> Bugs: MESOS-8974
>     https://issues.apache.org/jira/browse/MESOS-8974
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> JWT implementation can handle multiple type of keys for signing and
> validating JSON web tokens. IETF defined a JSON representation of those
> keys in
> https://tools.ietf.org/html/rfc7517. This review implements this RFC.
> 
> This commit adds a parser to convert a JSON into a JWK set containing
> RSA keys compatible with the implementation of RS256 in the JWT library.
> 
> The parser only supports parsing of  RSA keys for now but it can support
> multiple types of keys such as elliptic curve keys and symmetric keys
> as documented in the JWA RFC.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/Makefile.am d434001fbc49d337b6e29f6ac8c9c7475922a819 
>   3rdparty/libprocess/include/process/jwk.hpp PRE-CREATION 
>   3rdparty/libprocess/include/process/jwk_rsa.hpp PRE-CREATION 
>   3rdparty/libprocess/include/process/jwk_set.hpp PRE-CREATION 
>   3rdparty/libprocess/src/jwk_rsa.cpp PRE-CREATION 
>   3rdparty/libprocess/src/jwk_set.cpp PRE-CREATION 
>   3rdparty/libprocess/src/tests/jwk_set_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67425/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Clement Michaud
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message