mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 67065: Added a new stout utility header file which interfaces with libarchive.
Date Mon, 04 Jun 2018 21:10:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67065/#review204275
-----------------------------------------------------------


Ship it!




A bunch of minor things that I'll fix before committing.


3rdparty/stout/include/stout/archiver.hpp
Lines 71-76 (patched)
<https://reviews.apache.org/r/67065/#comment286686>

    Two newlines too many here.  I can fixup before committing.



3rdparty/stout/tests/CMakeLists.txt
Lines 106 (patched)
<https://reviews.apache.org/r/67065/#comment286687>

    Extraneous newline which seems to have snuck into the review.  I'll remove before committing.



3rdparty/stout/tests/archiver_tests.cpp
Lines 42 (patched)
<https://reviews.apache.org/r/67065/#comment286688>

    s/os::getcwd()/sandbox.get()/
    
    Here and throughout the test.  The TemporaryDirectoryTest defines this variable so that
we don't need to make that call repeatedly.



3rdparty/stout/tests/archiver_tests.cpp
Lines 52 (patched)
<https://reviews.apache.org/r/67065/#comment286689>

    A few periods missing on comments like this throughout this file.



3rdparty/stout/tests/archiver_tests.cpp
Lines 94 (patched)
<https://reviews.apache.org/r/67065/#comment286690>

    s/fo/to/



3rdparty/stout/tests/archiver_tests.cpp
Lines 411 (patched)
<https://reviews.apache.org/r/67065/#comment286691>

    s/extrat/extract/



3rdparty/stout/tests/archiver_tests.cpp
Lines 457-458 (patched)
<https://reviews.apache.org/r/67065/#comment286692>

    This test passes on non-Windows too, so it's better not to `#ifdef` it.


- Joseph Wu


On June 4, 2018, 12:11 p.m., John Kordich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67065/
> -----------------------------------------------------------
> 
> (Updated June 4, 2018, 12:11 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, Eric Mumau,
Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8064
>     https://issues.apache.org/jira/browse/MESOS-8064
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This archiver utility can be invoked to extract a compressed or
> uncompressed archive with several different supported formats.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/CMakeLists.txt 24a1f0acbee8a464fcc5159cf41d7e93aa8148fc 
>   3rdparty/stout/Makefile.am ef22a02a8a11326c6af19eb11d79eb82ff7861da 
>   3rdparty/stout/include/Makefile.am e0097c438a62a9802d6e60c78493bf97333f20ed 
>   3rdparty/stout/include/stout/archiver.hpp PRE-CREATION 
>   3rdparty/stout/tests/CMakeLists.txt 86111a8709cab709ba1bf844043d3a1da07b6241 
>   3rdparty/stout/tests/archiver_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67065/diff/8/
> 
> 
> Testing
> -------
> 
> I've built on Windows with CMake and have run all tests, which all pass.
> I've also built on Linux with both the autotools build and cmake build and have run all
tests, which all pass.
> 
> 
> Thanks,
> 
> John Kordich
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message