mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 67372: Updated sorter tests to run against multiple sorters where possible.
Date Mon, 04 Jun 2018 19:17:10 GMT


> On June 1, 2018, 9:37 p.m., Meng Zhu wrote:
> > src/tests/sorter_tests.cpp
> > Lines 1622-1623 (original), 1620-1621 (patched)
> > <https://reviews.apache.org/r/67372/diff/1/?file=2031737#file2031737line1636>
> >
> >     Why are you changing the original setup and only benchmarking one value?

I probably shouldn't be tweaking this in this patch instead of its own patch. :)

There were previously 36 testing parameters which took a long time to run, but in order to
run them to completion I had to reduce the number of configurations, so I figured I would
just include the max number of agents and clients, and if someone wants to run them with fewer
they can update the code.

I'll update this patch to avoid changing the values, we can follow up with tweaking them.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67372/#review204204
-----------------------------------------------------------


On May 30, 2018, 1:02 a.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67372/
> -----------------------------------------------------------
> 
> (Updated May 30, 2018, 1:02 a.m.)
> 
> 
> Review request for mesos, Gaston Kleiman, Greg Mann, and Meng Zhu.
> 
> 
> Bugs: MESOS-8936
>     https://issues.apache.org/jira/browse/MESOS-8936
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Several of the sorter tests, including the benchmarks, were agnostic
> to the sorter implementation. These have been updated to run for both
> `DRFSorter` and `RandomSorter`. The remainder have been updated to
> be called DRFSorter tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/sorter_tests.cpp da4e0f64a565af1d9458ff256ae0eafddd0a6b68 
> 
> 
> Diff: https://reviews.apache.org/r/67372/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message