mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 67065: Added a new stout utility header file which interfaces with libarchive.
Date Mon, 04 Jun 2018 18:09:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67065/#review204263
-----------------------------------------------------------




3rdparty/stout/include/stout/archiver.hpp
Lines 20-22 (patched)
<https://reviews.apache.org/r/67065/#comment286664>

    I still don't think this is necessary here.
    
    Joe had said in an issue:
    
    > This definition should go into the CMake file(s):
    > # This is a definition that only has an effect on Windows and is necessary
    > # when building a static libarchive instead of a DLL.
    > `target_compile_definitions(libarchive PUBLIC LIBARCHIVE_STATIC)`
    
    And then you said in a new iteration:
    
    > Updated to include a comment about why we need a define. There were plans to set
this define at a global level inside the cmake build using the target_compile_definitions
cmake function, but this function is available for IMPORTED targets only in cmake versions
> 3.11. We don't want to bump the required version of cmake for such a small change, so
we kept the #define in this file.
    
    But that's because for imported targets, you're "supposed" to set properties manually.
So this should instead look like:
    
    ```
    set_target_properties(
      archive PROPERTIES
      INTERFACE_COMPILE_DEFINITIONS LIBARCHIVE_STATIC)
    ```


- Andrew Schwartzmeyer


On June 1, 2018, 3:40 p.m., John Kordich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67065/
> -----------------------------------------------------------
> 
> (Updated June 1, 2018, 3:40 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, Eric Mumau,
Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8064
>     https://issues.apache.org/jira/browse/MESOS-8064
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This archiver utility can be invoked to extract a compressed or
> uncompressed archive with several different supported formats.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/CMakeLists.txt 24a1f0acbee8a464fcc5159cf41d7e93aa8148fc 
>   3rdparty/stout/Makefile.am ef22a02a8a11326c6af19eb11d79eb82ff7861da 
>   3rdparty/stout/include/Makefile.am e0097c438a62a9802d6e60c78493bf97333f20ed 
>   3rdparty/stout/include/stout/archiver.hpp PRE-CREATION 
>   3rdparty/stout/tests/CMakeLists.txt 86111a8709cab709ba1bf844043d3a1da07b6241 
>   3rdparty/stout/tests/archiver_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67065/diff/7/
> 
> 
> Testing
> -------
> 
> I've built on Windows with CMake and have run all tests, which all pass.
> I've also built on Linux with both the autotools build and cmake build and have run all
tests, which all pass.
> 
> 
> Thanks,
> 
> John Kordich
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message