mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 67413: Added `PYTHON_2` and `PYTHON_3` environment variables in `configure.ac`.
Date Sat, 02 Jun 2018 01:24:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67413/#review204213
-----------------------------------------------------------



Patch looks great!

Reviews applied: [67411, 67412, 67413]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On June 1, 2018, 8:21 a.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67413/
> -----------------------------------------------------------
> 
> (Updated June 1, 2018, 8:21 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, and Kevin
Klues.
> 
> 
> Bugs: MESOS-8955
>     https://issues.apache.org/jira/browse/MESOS-8955
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> These variables will soon be used to build the Python bindings and
> the CLI. The goal is to have a clear situation regarding which
> version of python is used to build each part of our codebase.
> 
> 
> Diffs
> -----
> 
>   configure.ac 03d333d65bcab2e46cff0b1329e5ad7bb26da697 
> 
> 
> Diff: https://reviews.apache.org/r/67413/diff/1/
> 
> 
> Testing
> -------
> 
> I added two lines after the new code:
> 
> ```
> AC_MSG_NOTICE([$PYTHON_2])
> AC_MSG_NOTICE([$PYTHON_3])
> ```
> 
> My machine runs Python 2 when using `python` but `python3` is available. The result of
`configure` was:
> ```
> configure: /usr/bin/python
> configure: python3
> ```
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message