mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Kordich via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 67064: Added libarchive, bzip2, and xz patches and associated build changes.
Date Fri, 01 Jun 2018 21:58:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67064/
-----------------------------------------------------------

(Updated June 1, 2018, 9:58 p.m.)


Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, Eric Mumau,
Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.


Changes
-------

Addressed Joseph Wu's build issues:
Added ENABLE_LZ4 option to the CMake build of libarchive, so that we can disable it.
Disabled all flags to libarchive that are unnecessary as part of the autotools build.


Bugs: MESOS-8064
    https://issues.apache.org/jira/browse/MESOS-8064


Repository: mesos


Description
-------

These libraries being available will allow stout to be changed such that
stout can invoke libarchive instead of shelling out to tar to extract
archives. On Windows, tar usually doesn't exist, and even if it does, it
rarely supports most compression formats. On Windows, we will build
libarchive to support each of those compression formats.


Diffs (updated)
-----

  3rdparty/CMakeLists.txt ecb6946401d9b81c6610cf9f33dcf2caa9ff0f04 
  3rdparty/Makefile.am 062df18643cadb4f8f5bcbd56c1dad63a7b8f894 
  3rdparty/bzip2-1.0.6.patch PRE-CREATION 
  3rdparty/cmake/Versions.cmake 2828acd2aa00c8778c6c462bc594716b2b6289ba 
  3rdparty/libarchive-3.3.2.patch PRE-CREATION 
  3rdparty/versions.am ada998d62d012a45b2cf17256c1ae16b92d611f2 
  3rdparty/xz-5.2.3.patch PRE-CREATION 
  configure.ac 03d333d65bcab2e46cff0b1329e5ad7bb26da697 
  src/Makefile.am b7184ceccef5f2e985d905c155156f95c7a7c7b4 


Diff: https://reviews.apache.org/r/67064/diff/7/

Changes: https://reviews.apache.org/r/67064/diff/6-7/


Testing
-------

I've built on Windows with CMake and have run all tests, which all pass.
I've also built on Linux with both the autotools build and cmake build and have run all tests,
which all pass.


Thanks,

John Kordich


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message