mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 67344: WIP: Made disk allocatable on their own.
Date Fri, 01 Jun 2018 15:41:21 GMT


> On May 31, 2018, 10:34 p.m., Benjamin Mahler wrote:
> > Gaston is also working on making the allocation "minimums" configurable, e.g.
> > 
> > ```
> > Probably want to have an AND by default to avoid MESOS-8935:
> > --allocation_minimums=cpus:0.01;mem:32
> > 
> > Currently we have effectively an OR:
> > --allocation_minimums=cpus:0.01,mem:32
> > ```
> > 
> > We would probably want this default to be an AND of resources to avoid MESOS-8935.
Once we have "storage" frameworks that only want disk, we would probably allow a per-framework
override of the allocation minimums, requiring those special frameworks to specify their minimums.
> > 
> > Make sense?

I updated this patch with another test case, but I believe this is now blocked by Gaston's/Greg's
work. Will leave the patch as `WIP` for now.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67344/#review204142
-----------------------------------------------------------


On June 1, 2018, 5:41 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67344/
> -----------------------------------------------------------
> 
> (Updated June 1, 2018, 5:41 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gaston Kleiman, Greg Mann, and Jie Yu.
> 
> 
> Bugs: MESOS-8626
>     https://issues.apache.org/jira/browse/MESOS-8626
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch makes it possible to offer `disk` resources in isolation
> which previously was only possible for `cpus` or `mem` resources.
> 
> While it is not possible to perform launch operations on `disk`
> resources alone, frameworks could still perform most other operations
> on them. With the introduction of resource providers we introduced
> operations which do not take effect immediately, but only after the
> master has received a status update on the operations success, so that
> with the changes here frameworks can now operate on `disk` resources
> independently of task launch operations.
> 
> Since resource provider resources are independent from agent-default
> resources, the full agent resources are not necessarily in the same
> role. Due to the way the default allocator takes roles into account,
> this could in the past have lead to situations where it was impossible
> to find suitable `cpus` or `mem` resources to make `disk` resources
> from some other role offerable at all. This problem also disappears if
> `disk` become offerable on their own.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp b558228290e5ae6dbcc1b8a6e1fe69db9fd5874c

>   src/master/constants.hpp b31e5f027b44d371050cea9a4662a4b54127812f 
>   src/tests/hierarchical_allocator_tests.cpp c97b2ba0884a7ded867c2d80e4749de54c89b5e4

>   src/tests/master_allocator_tests.cpp e1aef8a9625a805e7ad2dfad37bfeedee82f160d 
>   src/tests/persistent_volume_tests.cpp 43f31b2e613666a989c205b8543ef1cde484d93c 
> 
> 
> Diff: https://reviews.apache.org/r/67344/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message