mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Review Request 67412: Improved coverage with configure and `PYTHON` or `PYTHON_VERSION` set.
Date Fri, 01 Jun 2018 15:14:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67412/
-----------------------------------------------------------

Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, and Kevin Klues.


Bugs: MESOS-8955
    https://issues.apache.org/jira/browse/MESOS-8955


Repository: mesos


Description
-------

We set `PYTHON` and `PYTHON_VERSION` when configuring the build.
We now cover all possible cases (both variables set, only one, none).
This ensures that both variables are set after being checked.


Diffs
-----

  configure.ac 03d333d65bcab2e46cff0b1329e5ad7bb26da697 


Diff: https://reviews.apache.org/r/67412/diff/1/


Testing
-------

I added two lines after the new code:
```
  AC_MSG_NOTICE([$PYTHON])
  AC_MSG_NOTICE([$PYTHON_VERSION])
```

Then, when using `configure`, I've checked the output.
```
$ ../configure 
...
configure: /usr/bin/python
configure: 2.7
$ PYTHON_VERSION=4 ../configure
...
configure: python4
configure: 4
$ PYTHON=yolo ../configure
...
configure: yolo
configure:
```


Thanks,

Armand Grillet


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message