mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 67403: Handled race condition when removing maintenance windows.
Date Fri, 01 Jun 2018 14:17:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67403/
-----------------------------------------------------------

(Updated June 1, 2018, 2:17 p.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Bugs: MESOS-7966
    https://issues.apache.org/jira/browse/MESOS-7966


Repository: mesos


Description
-------

When executing the `Master::inverseOffers()` callback, it
could happen that the maintenance window the reverse offer
referred to was already removed by a concurrent call to
to the maintenance endpoint of Mesos.

In this case, we must not send out a reverse offer, because
having outstanding inverse offers for an agent without
any scheduled maintenance window will lead to a crash in
the allocator when attempting to remove this offer.


Diffs (updated)
-----

  src/master/master.cpp ba3f8746ea393c8655fcd5ceaace099f68df0b19 


Diff: https://reviews.apache.org/r/67403/diff/2/

Changes: https://reviews.apache.org/r/67403/diff/1-2/


Testing
-------

`make check`

Set up the reproduction environment locally and ran `while :; python call.py; done` for about
a minute. (see linked ticket)


Thanks,

Benno Evers


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message