mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 67343: Automatically loaded all the local enabled cgroups subsystems.
Date Fri, 01 Jun 2018 03:21:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67343/
-----------------------------------------------------------

(Updated June 1, 2018, 11:21 a.m.)


Review request for mesos and Gilbert Song.


Changes
-------

Addressed review comments.


Bugs: MESOS-7691
    https://issues.apache.org/jira/browse/MESOS-7691


Repository: mesos


Description
-------

When `cgroups/all` is specified in the agent flag `--isolation`, we
will automatically load all the local enabled cgroups subsystems in
the cgroups isolator with one exception: the `perf_event` subsystem,
we will only automatically load it when the agent flag `--perf_events`
is specified, otherwise it will be skipped.


Diffs (updated)
-----

  src/slave/containerizer/mesos/containerizer.cpp 17a1a3762b2012ff875e4da9c9d4622514e48051

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 215e32461e851668247f9fae62aa656f5dd5e245



Diff: https://reviews.apache.org/r/67343/diff/4/

Changes: https://reviews.apache.org/r/67343/diff/3-4/


Testing
-------

sudo make check


Thanks,

Qian Zhang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message