From reviews-return-77937-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue May 22 22:55:40 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C2534188F7 for ; Tue, 22 May 2018 22:55:40 +0000 (UTC) Received: (qmail 29879 invoked by uid 500); 22 May 2018 22:55:40 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 29843 invoked by uid 500); 22 May 2018 22:55:40 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 29832 invoked by uid 99); 22 May 2018 22:55:40 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 May 2018 22:55:40 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 9F0D3CA2F7; Tue, 22 May 2018 22:55:39 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.336 X-Spam-Level: ** X-Spam-Status: No, score=2.336 tagged_above=-999 required=6.31 tests=[FORGED_HOTMAIL_RCVD2=1.187, HEADER_FROM_DIFFERENT_DOMAINS=0.249, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_MANYTO=0.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 5WQg0r_eBM2P; Tue, 22 May 2018 22:55:38 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 9F4175F5B2; Tue, 22 May 2018 22:55:38 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 444FAE00FC; Tue, 22 May 2018 22:55:38 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 302FEC40222; Tue, 22 May 2018 22:55:38 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1233784258602379313==" MIME-Version: 1.0 Subject: Re: Review Request 66962: Windows: Added tests for async IO functions. From: Akash Gupta To: Benjamin Mahler , Eric Mumau , Radhika Jandhyala , Joseph Wu , Andrew Schwartzmeyer , John Kordich Cc: Mesos Reviewbot , Mesos Reviewbot Windows , Akash Gupta , mesos Date: Tue, 22 May 2018 22:55:38 -0000 Message-ID: <20180522225538.19045.7565@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Akash Gupta X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/66962/ X-Sender: Akash Gupta References: <20180504172704.31648.86785@reviews-vm2.apache.org> In-Reply-To: <20180504172704.31648.86785@reviews-vm2.apache.org> Reply-To: Akash Gupta X-ReviewRequest-Repository: mesos --===============1233784258602379313== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66962/ ----------------------------------------------------------- (Updated May 22, 2018, 10:55 p.m.) Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, John Kordich, Joseph Wu, and Radhika Jandhyala. Changes ------- Addressed feedback. Bugs: MESOS-8670 https://issues.apache.org/jira/browse/MESOS-8670 Repository: mesos Description ------- New asynchronous functions were introduced to the Windows stout read and write implementations, so eztra tests were added. Diffs (updated) ----- 3rdparty/stout/tests/os/filesystem_tests.cpp b17ab9aaa94ae14b6707a9ac7a54b9db38615f2a Diff: https://reviews.apache.org/r/66962/diff/2/ Changes: https://reviews.apache.org/r/66962/diff/1-2/ Testing ------- Thanks, Akash Gupta --===============1233784258602379313==--