From reviews-return-77935-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue May 22 22:53:21 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8CBE6188E5 for ; Tue, 22 May 2018 22:53:21 +0000 (UTC) Received: (qmail 27938 invoked by uid 500); 22 May 2018 22:53:21 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 27900 invoked by uid 500); 22 May 2018 22:53:21 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 27889 invoked by uid 99); 22 May 2018 22:53:20 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 May 2018 22:53:20 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 6259E1803CE; Tue, 22 May 2018 22:53:20 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.326 X-Spam-Level: ** X-Spam-Status: No, score=2.326 tagged_above=-999 required=6.31 tests=[FORGED_HOTMAIL_RCVD2=1.187, HEADER_FROM_DIFFERENT_DOMAINS=0.249, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_MANYTO=0.2, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id U0nn66boQ7ex; Tue, 22 May 2018 22:53:19 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 62FAA5F16A; Tue, 22 May 2018 22:53:18 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id AD572E00FC; Tue, 22 May 2018 22:53:17 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 97824C40222; Tue, 22 May 2018 22:53:17 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0880290242561662380==" MIME-Version: 1.0 Subject: Re: Review Request 66960: Windows: Added async version of `os::sendfile`. From: Akash Gupta To: Benjamin Mahler , Eric Mumau , Radhika Jandhyala , Joseph Wu , Andrew Schwartzmeyer , John Kordich Cc: Akash Gupta , mesos Date: Tue, 22 May 2018 22:53:17 -0000 Message-ID: <20180522225317.19045.2417@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Akash Gupta X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/66960/ X-Sender: Akash Gupta References: <20180504171841.31648.69664@reviews-vm2.apache.org> In-Reply-To: <20180504171841.31648.69664@reviews-vm2.apache.org> Reply-To: Akash Gupta X-ReviewRequest-Repository: mesos --===============0880290242561662380== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66960/ ----------------------------------------------------------- (Updated May 22, 2018, 10:53 p.m.) Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, John Kordich, Joseph Wu, and Radhika Jandhyala. Changes ------- Addressed feedback. Bugs: MESOS-8681 https://issues.apache.org/jira/browse/MESOS-8681 Repository: mesos Description ------- Broke the original `os::sendfile` implementation into an asynchronous `os::sendfile_async`function and a synchronous `os::sendfile` function. The synchronous version simply calls the asynchronous version and waits. Diffs (updated) ----- 3rdparty/stout/include/stout/os/windows/sendfile.hpp 594d9c7beeff2766f59f16ba25986314f2f7ceb8 Diff: https://reviews.apache.org/r/66960/diff/2/ Changes: https://reviews.apache.org/r/66960/diff/1-2/ Testing ------- Thanks, Akash Gupta --===============0880290242561662380==--