From reviews-return-77432-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu May 10 13:43:29 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9E60518BF6 for ; Thu, 10 May 2018 13:43:29 +0000 (UTC) Received: (qmail 3287 invoked by uid 500); 10 May 2018 13:43:29 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 3258 invoked by uid 500); 10 May 2018 13:43:29 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 3245 invoked by uid 99); 10 May 2018 13:43:28 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 May 2018 13:43:28 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 6F076C7606; Thu, 10 May 2018 13:43:28 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.7 X-Spam-Level: X-Spam-Status: No, score=0.7 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id Cbt0hUg_xQzW; Thu, 10 May 2018 13:43:26 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id BB8575F1B4; Thu, 10 May 2018 13:43:25 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6E4CBE00C9; Thu, 10 May 2018 13:43:25 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 35B22C4021E; Thu, 10 May 2018 13:43:25 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2147338698763934945==" MIME-Version: 1.0 Subject: Re: Review Request 67055: Added Python 3 version of cpplint. From: Mesos Reviewbot Windows To: Benjamin Bannier , Kevin Klues , Andrew Schwartzmeyer , Eric Chung Cc: Mesos Reviewbot Windows , Armand Grillet , mesos Date: Thu, 10 May 2018 13:43:25 -0000 Message-ID: <20180510134325.35331.35461@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot Windows X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/67055/ X-Sender: Mesos Reviewbot Windows References: <20180510113606.35331.77586@reviews-vm2.apache.org> In-Reply-To: <20180510113606.35331.77586@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: support/python3/cpplint.patch X-ReviewBoard-Diff-For: support/python3/cpplint.py Reply-To: Mesos Reviewbot Windows X-ReviewRequest-Repository: mesos --===============2147338698763934945== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67055/#review202842 ----------------------------------------------------------- PASS: Mesos patch 67055 was successfully built and tested. Reviews applied: `['67055']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67055 - Mesos Reviewbot Windows On May 10, 2018, 11:36 a.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67055/ > ----------------------------------------------------------- > > (Updated May 10, 2018, 11:36 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, and Kevin Klues. > > > Bugs: MESOS-8770 > https://issues.apache.org/jira/browse/MESOS-8770 > > > Repository: mesos > > > Description > ------- > > The Python 3 supports scripts currently live in support/python3. > Once all support scripts will have been updated to Python 3 and > tested by the developers, we will replace the Python 2 scripts by > the new ones in an ongoing effort of modernizing our Python codebase. > > > Diffs > ----- > > support/python3/cpplint.patch PRE-CREATION > support/python3/cpplint.py PRE-CREATION > > > Diff: https://reviews.apache.org/r/67055/diff/1/ > > > Testing > ------- > > Used `mesos-style.py` with the old `cpplint.py` (no change on `mesos-style.py`): > ``` > apache-mesos (cpplint) $ ./support/mesos-style.py > Checking 1289 C++ files > Total errors found: 0 > Checking 4 JavaScript files > Total errors found: 0 > Checking 47 Python files > py27-lint: commands succeeded > congratulations :) > py27-lint: commands succeeded > congratulations :) > Total errors found: 0 > ``` > Updated `mesos-style.py` to use the new version of cpplint: > ``` > # We do not use a version of cpplint available through pip as > # we use a custom version (see cpplint.path) to lint C++ files. > process = subprocess.Popen( > ['python3', 'support/python3/cpplint.py', rules_filter] + source_paths, > stderr=subprocess.PIPE, > close_fds=True) > ``` > > Run `mesos-style.py` again: > ``` > apache-mesos (cpplint) $ ./support/mesos-style.py > Checking 1289 C++ files > Total errors found: 0 > Checking 4 JavaScript files > Total errors found: 0 > Checking 47 Python files > py27-lint: commands succeeded > congratulations :) > py27-lint: commands succeeded > congratulations :) > ************* Module mesos-style > C:279, 0: Line too long (83/80) (line-too-long) > Total errors found: 1 > ``` > As we can see, the number of errors found by cpplint is the same as before. > > I have also used cpplint separately bu running `python3 support/python3/cpplint` on a few C++ files to see that it was running as expected. > > > Thanks, > > Armand Grillet > > --===============2147338698763934945==--