From reviews-return-77372-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed May 9 13:15:26 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 101D5185CB for ; Wed, 9 May 2018 13:15:26 +0000 (UTC) Received: (qmail 33696 invoked by uid 500); 9 May 2018 13:15:25 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 33660 invoked by uid 500); 9 May 2018 13:15:25 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 33649 invoked by uid 99); 9 May 2018 13:15:25 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 May 2018 13:15:25 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id CC606C6DB4; Wed, 9 May 2018 13:15:24 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.701 X-Spam-Level: X-Spam-Status: No, score=0.701 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 3nFqlloLrXS2; Wed, 9 May 2018 13:15:23 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 871265F178; Wed, 9 May 2018 13:15:23 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id EF4E7E0047; Wed, 9 May 2018 13:15:22 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 77640C40228; Wed, 9 May 2018 13:15:22 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7927455112167761140==" MIME-Version: 1.0 Subject: Re: Review Request 66993: Removed unnecessary expectation on termination. From: Mesos Reviewbot To: Andrei Budnik , James Peach Cc: Zhitao Li , Mesos Reviewbot , mesos Date: Wed, 09 May 2018 13:15:22 -0000 Message-ID: <20180509131522.18674.21617@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/66993/ X-Sender: Mesos Reviewbot References: <20180508203652.43223.65910@reviews-vm2.apache.org> In-Reply-To: <20180508203652.43223.65910@reviews-vm2.apache.org> Reply-To: Mesos Reviewbot X-ReviewRequest-Repository: mesos --===============7927455112167761140== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66993/#review202750 ----------------------------------------------------------- Patch looks great! Reviews applied: [66993] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On May 8, 2018, 8:36 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66993/ > ----------------------------------------------------------- > > (Updated May 8, 2018, 8:36 p.m.) > > > Review request for mesos, Andrei Budnik and James Peach. > > > Bugs: MESOS-8884 > https://issues.apache.org/jira/browse/MESOS-8884 > > > Repository: mesos > > > Description > ------- > > This test was flaky because termination could already happened when we > set up the expectation. Given that we already verified task state, I do > not see checking container termination explicitly is necessary, so > removing the expectation should fix the flakiness. > > > Diffs > ----- > > src/tests/containerizer/docker_containerizer_tests.cpp d834e531a550028cd57ac409c9312dd22138e8d5 > > > Diff: https://reviews.apache.org/r/66993/diff/2/ > > > Testing > ------- > > GTEST_FILTER="DockerContainerizerTest.ROOT_DOCKER_MaxCompletionTime" ./bin/mesos-tests.sh --gtest_repeat=100 --verbose > > > Thanks, > > Zhitao Li > > --===============7927455112167761140==--