From reviews-return-77098-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri May 4 03:52:40 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AE1E618E19 for ; Fri, 4 May 2018 03:52:40 +0000 (UTC) Received: (qmail 96822 invoked by uid 500); 4 May 2018 03:52:40 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 96780 invoked by uid 500); 4 May 2018 03:52:39 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 96765 invoked by uid 99); 4 May 2018 03:52:38 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 May 2018 03:52:38 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 33041C05EC; Fri, 4 May 2018 03:52:38 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.941 X-Spam-Level: X-Spam-Status: No, score=0.941 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id D8ch2hOKs19B; Fri, 4 May 2018 03:52:37 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id CC0C45F59D; Fri, 4 May 2018 03:52:36 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 68E1BE00EA; Fri, 4 May 2018 03:52:36 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 31D69C405B0; Fri, 4 May 2018 03:52:36 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3551545208539110590==" MIME-Version: 1.0 Subject: Re: Review Request 66749: Added more logging to agent recovery path. From: Meng Zhu To: Chun-Hung Hsiao , Gaston Kleiman , Greg Mann Cc: Mesos Reviewbot , Mesos Reviewbot Windows , Meng Zhu , mesos Date: Fri, 04 May 2018 03:52:36 -0000 Message-ID: <20180504035236.43656.92739@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Meng Zhu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/66749/ X-Sender: Meng Zhu References: <20180423223011.64394.25392@reviews-vm2.apache.org> In-Reply-To: <20180423223011.64394.25392@reviews-vm2.apache.org> Reply-To: Meng Zhu X-ReviewRequest-Repository: mesos --===============3551545208539110590== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66749/ ----------------------------------------------------------- (Updated May 3, 2018, 8:52 p.m.) Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann. Bugs: MESOS-8793 https://issues.apache.org/jira/browse/MESOS-8793 Repository: mesos Description ------- Added logging in some agent recovery continuations to make analyzing agent recovery related issue less painful. Diffs (updated) ----- src/slave/containerizer/composing.cpp 186102c66d373dcd799cadd9fed7d1c8cb894971 src/slave/containerizer/docker.cpp a4c9c10e91e75f406329cbb2086f39b549cbeed0 src/slave/containerizer/mesos/containerizer.cpp 01386ac3d36ec7a401b8d1be7834bc1f3fce55ef src/slave/containerizer/mesos/linux_launcher.cpp af34a856e092a880a0809da34ead9d8588b0ac8f src/slave/slave.cpp 6ca3d79fd38c800f258c571bb58164427db2ac7c Diff: https://reviews.apache.org/r/66749/diff/3/ Changes: https://reviews.apache.org/r/66749/diff/2-3/ Testing ------- make check Thanks, Meng Zhu --===============3551545208539110590==--