From reviews-return-77097-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri May 4 03:44:47 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7C1C818DF3 for ; Fri, 4 May 2018 03:44:47 +0000 (UTC) Received: (qmail 89465 invoked by uid 500); 4 May 2018 03:44:47 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 89410 invoked by uid 500); 4 May 2018 03:44:46 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 89387 invoked by uid 99); 4 May 2018 03:44:44 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 May 2018 03:44:44 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 7DFC81807FE; Fri, 4 May 2018 03:44:44 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.939 X-Spam-Level: X-Spam-Status: No, score=0.939 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.249, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id HHDp6tF_FbUN; Fri, 4 May 2018 03:44:43 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 3406A5F1F0; Fri, 4 May 2018 03:44:43 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C08A1E00EA; Fri, 4 May 2018 03:44:42 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id A669AC405B0; Fri, 4 May 2018 03:44:42 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5580331858684966050==" MIME-Version: 1.0 Subject: Re: Review Request 66938: Made the 'SchedulerDriver' abort when operation's 'id' field is set. From: Gaston Kleiman To: Benjamin Bannier , Vinod Kone , Gaston Kleiman , Jan Schlicht Cc: Greg Mann , mesos Date: Fri, 04 May 2018 03:44:42 -0000 Message-ID: <20180504034442.43657.46454@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Gaston Kleiman X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/66938/ X-Sender: Gaston Kleiman X-ReviewBoard-ShipIt: 1 References: <20180503231456.43657.45139@reviews-vm2.apache.org> In-Reply-To: <20180503231456.43657.45139@reviews-vm2.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Gaston Kleiman X-ReviewRequest-Repository: mesos --===============5580331858684966050== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66938/#review202413 ----------------------------------------------------------- Ship it! Ship It! - Gaston Kleiman On May 3, 2018, 4:14 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66938/ > ----------------------------------------------------------- > > (Updated May 3, 2018, 4:14 p.m.) > > > Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jan Schlicht, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Since the 'SchedulerDriver' does not support operation status updates, > this patch adds a check to the driver which will abort the scheduler > if the 'id' field is set in an offer operation. > > > Diffs > ----- > > src/sched/sched.cpp 620a3b26d8bf3487b6ce922b2280be7da291df06 > > > Diff: https://reviews.apache.org/r/66938/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Greg Mann > > --===============5580331858684966050==--