From reviews-return-77036-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed May 2 23:08:20 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B88A5184AB for ; Wed, 2 May 2018 23:08:20 +0000 (UTC) Received: (qmail 39052 invoked by uid 500); 2 May 2018 23:08:20 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 39020 invoked by uid 500); 2 May 2018 23:08:20 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 39005 invoked by uid 99); 2 May 2018 23:08:19 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 May 2018 23:08:19 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 72140C7FF4; Wed, 2 May 2018 23:08:19 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.7 X-Spam-Level: X-Spam-Status: No, score=0.7 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id VbcKa7zQ4dbN; Wed, 2 May 2018 23:08:18 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 942935F522; Wed, 2 May 2018 23:08:17 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D327CE012E; Wed, 2 May 2018 23:08:16 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 95FF9C4015B; Wed, 2 May 2018 23:08:16 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3942754759257896916==" MIME-Version: 1.0 Subject: Re: Review Request 66919: Failure to update registry should abort the master process. From: Mesos Reviewbot Windows To: Xudong Ni , Mesos Reviewbot Windows , mesos Date: Wed, 02 May 2018 23:08:16 -0000 Message-ID: <20180502230816.43564.10951@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot Windows X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/66919/ X-Sender: Mesos Reviewbot Windows References: <20180502213846.43565.82114@reviews-vm2.apache.org> In-Reply-To: <20180502213846.43565.82114@reviews-vm2.apache.org> Reply-To: Mesos Reviewbot Windows X-ReviewRequest-Repository: mesos --===============3942754759257896916== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66919/#review202327 ----------------------------------------------------------- PASS: Mesos patch 66919 was successfully built and tested. Reviews applied: `['66919']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66919 - Mesos Reviewbot Windows On May 2, 2018, 11:38 p.m., Xudong Ni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66919/ > ----------------------------------------------------------- > > (Updated May 2, 2018, 11:38 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-8630 > https://issues.apache.org/jira/browse/MESOS-8630 > > > Repository: mesos > > > Description > ------- > > When the registrar fails to update the registry it would abort the > actor and fail all future operations,However when the registrar > updates is requested by an operator API such as maintenance update, > the master process doesn't shut down (a 500 error is returned to the > client instead)and all subsequent operations will fail. > > Review: https://reviews.apache.org/r/66919 > > > Diffs > ----- > > src/master/http.cpp 135ae4389623385a6638158f5f23d6daca14a0ad > > > Diff: https://reviews.apache.org/r/66919/diff/1/ > > > Testing > ------- > > No error found by running all unit tests(make check) > > > Thanks, > > Xudong Ni > > --===============3942754759257896916==--