| Akash Gupta |
Review Request 66952: Windows: Added overlapped field to WindowsFD. |
Fri, 04 May, 17:15 |
| Akash Gupta |
Review Request 66953: Windows: Fixed dup to properly copy the overlapped WindowsFD. |
Fri, 04 May, 17:16 |
| Akash Gupta |
Review Request 66961: Windows: Ported sendfile_tests.cpp. |
Fri, 04 May, 17:17 |
| Akash Gupta |
Review Request 66960: Windows: Added async version of `os::sendfile`. |
Fri, 04 May, 17:18 |
| Akash Gupta |
Review Request 66959: Windows: Fixed pipe inheritance in Mesos containerizer. |
Fri, 04 May, 17:19 |
| Akash Gupta |
Review Request 66958: Windows: Fixed inheritance in subprocess_windows.cpp. |
Fri, 04 May, 17:20 |
| Akash Gupta |
Review Request 66957: Windows: Enabled creating overlapped pipes with `os::pipe`. |
Fri, 04 May, 17:20 |
| Akash Gupta |
Review Request 66956: Windows: Added overlapped support to `os::write`. |
Fri, 04 May, 17:21 |
| Akash Gupta |
Review Request 66955: Windows: Added overlapped support to `os::read`. |
Fri, 04 May, 17:21 |
| Akash Gupta |
Review Request 66954: Windows: Added overlapped aware io.hpp file for `os::read/write`. |
Fri, 04 May, 17:21 |
| Akash Gupta |
Review Request 66962: Windows: Added tests for async IO functions. |
Fri, 04 May, 17:27 |
| Akash Gupta |
Re: Review Request 66962: Windows: Added tests for async IO functions. |
Fri, 04 May, 19:38 |
| Akash Gupta |
Re: Review Request 66961: Windows: Ported sendfile_tests.cpp. |
Mon, 07 May, 23:15 |
| Akash Gupta |
Review Request 67207: Windows: Changed health check image to be an environment variable. |
Fri, 18 May, 09:07 |
| Akash Gupta |
Review Request 67208: Windows: Updated information on docker health checks. |
Fri, 18 May, 09:08 |
| Akash Gupta |
Review Request 67243: Windows: Changed test image to custom nanoserver. |
Tue, 22 May, 01:28 |
| Akash Gupta |
Re: Review Request 67243: Windows: Changed test image to custom nanoserver. |
Tue, 22 May, 01:39 |
| Akash Gupta |
Re: Review Request 66955: Windows: Added overlapped support to `os::read`. |
Tue, 22 May, 22:40 |
| Akash Gupta |
Re: Review Request 66956: Windows: Added overlapped support to `os::write`. |
Tue, 22 May, 22:46 |
| Akash Gupta |
Re: Review Request 66957: Windows: Enabled creating overlapped pipes with `os::pipe`. |
Tue, 22 May, 22:51 |
| Akash Gupta |
Re: Review Request 66958: Windows: Fixed inheritance in subprocess_windows.cpp. |
Tue, 22 May, 22:51 |
| Akash Gupta |
Re: Review Request 66960: Windows: Added async version of `os::sendfile`. |
Tue, 22 May, 22:53 |
| Akash Gupta |
Re: Review Request 66961: Windows: Ported sendfile_tests.cpp. |
Tue, 22 May, 22:54 |
| Akash Gupta |
Re: Review Request 66962: Windows: Added tests for async IO functions. |
Tue, 22 May, 22:55 |
| Akash Gupta |
Review Request 67313: Windows: Fixed `ROOT_DOCKER_DockerHealthStatusChange` test. |
Fri, 25 May, 02:52 |
| Akash Gupta |
Review Request 67384: Windows: Made socket `int_fd` castable to `HANDLE` type. |
Wed, 30 May, 18:39 |
| Akash Gupta |
Review Request 67393: Windows: Ported io_tests.cpp. |
Wed, 30 May, 18:40 |
| Akash Gupta |
Review Request 67392: Windows: Made PipeLargeOutput test work with IOCP backend. |
Wed, 30 May, 18:41 |
| Akash Gupta |
Review Request 67391: Windows: Added CMake `ENABLE_LIBWINIO` flag for Windows IOCP backend. |
Wed, 30 May, 18:42 |
| Akash Gupta |
Review Request 67390: Windows: Integrated libwinio with libprocess code. |
Wed, 30 May, 18:46 |
| Akash Gupta |
Review Request 67389: Windows: Implemented Windows IOCP async backend. |
Wed, 30 May, 18:54 |
| Akash Gupta |
Review Request 67388: Moved: `io::internal::read/write` to separate file. |
Wed, 30 May, 18:55 |
| Akash Gupta |
Review Request 67387: Updated Mesos code to use `io::prepare_async`. |
Wed, 30 May, 18:56 |
| Akash Gupta |
Review Request 67386: Added `io::prepare_async` and `io::is_async` functions for libprocess. |
Wed, 30 May, 18:56 |
| Akash Gupta |
Review Request 67385: Windows: Added IOCP `HANDLE` to `WindowsFD`. |
Wed, 30 May, 18:58 |
| Akash Gupta |
Re: Review Request 67389: Windows: Implemented Windows IOCP async backend. |
Wed, 30 May, 20:20 |
| Akash Gupta |
Re: Review Request 67389: Windows: Implemented Windows IOCP async backend. |
Wed, 30 May, 20:23 |
| Akash Gupta |
Review Request 67395: Fixed socket creation bug in docker.cpp. |
Thu, 31 May, 02:59 |
| Alexander Rojas |
Review Request 67339: Modified launch.cpp to writes its logs into cerr. |
Mon, 28 May, 10:37 |
| Alexander Rojas |
Review Request 67357: Added constant time comparison of JWT signatures. |
Tue, 29 May, 14:21 |
| Alexander Rojas |
Re: Review Request 67357: Added constant time comparison of JWT signatures. |
Thu, 31 May, 09:02 |
| Alexander Rukletsov |
Re: Review Request 67004: Added an option to keep downloaded patches to apply-reviews.py. |
Tue, 08 May, 16:44 |
| Alexander Rukletsov |
Re: Review Request 66799: Fixed flakyness in 'MasterAPITest.MasterFailover'. |
Tue, 08 May, 16:44 |
| Alexander Rukletsov |
Review Request 67217: Ensured `SlaveRegisteredMessage`s trigger appropriate expectations. |
Fri, 18 May, 18:30 |
| Alexander Rukletsov |
Re: Review Request 67217: Ensured `SlaveRegisteredMessage`s trigger appropriate expectations. |
Tue, 22 May, 12:43 |
| Alexander Rukletsov |
Review Request 67320: Sent task (health) check updates over the operator streaming API. |
Fri, 25 May, 10:21 |
| Alexander Rukletsov |
Re: Review Request 67320: Sent task (health) check updates over the operator streaming API. |
Fri, 25 May, 10:21 |
| Alexander Rukletsov |
Re: Review Request 67217: Ensured `SlaveRegisteredMessage`s trigger appropriate expectations. |
Fri, 25 May, 10:51 |
| Alexander Rukletsov |
Re: Review Request 67321: Fixed python3/post-reviews.py type error. |
Fri, 25 May, 12:03 |
| Alexander Rukletsov |
Re: Review Request 67320: Sent task (health) check updates over the operator streaming API. |
Fri, 25 May, 13:51 |
| Alexander Rukletsov |
Re: Review Request 67320: Sent task (health) check updates over the operator streaming API. |
Fri, 25 May, 13:52 |
| Alexander Rukletsov |
Re: Review Request 67339: Modified launch.cpp to write its logs into cerr. |
Mon, 28 May, 11:02 |
| Alexander Rukletsov |
Re: Review Request 67320: Sent task (health) check updates over the operator streaming API. |
Mon, 28 May, 11:25 |
| Alexander Rukletsov |
Re: Review Request 67345: Removed unchecked access to an optional in checker process. |
Mon, 28 May, 16:05 |
| Alexander Rukletsov |
Re: Review Request 67340: Fixed python3/mesos-style.py type error. |
Tue, 29 May, 09:47 |
| Alexander Rukletsov |
Re: Review Request 67401: Fixed segfault in libprocess due to order-of-evaluation bug. |
Thu, 31 May, 15:56 |
| Alexander Rukletsov |
Re: Review Request 67357: Added constant time comparison of JWT signatures. |
Thu, 31 May, 16:26 |
| Alexander Rukletsov |
Re: Review Request 67354: Removed `os::getenv()` calls from `MesosExecutorDriver`. |
Thu, 31 May, 16:36 |
| Alexander Rukletsov |
Re: Review Request 67354: Removed `os::getenv()` calls from `MesosExecutorDriver`. |
Thu, 31 May, 20:54 |
| Andrei Budnik |
Re: Review Request 66993: Removed unnecessary expectation on termination. |
Tue, 08 May, 14:22 |
| Andrei Budnik |
Re: Review Request 66993: Removed unnecessary expectation on termination. |
Tue, 08 May, 21:07 |
| Andrei Budnik |
Re: Review Request 66668: Removed `destroyed` from `Container` struct in composing containerizer. |
Fri, 11 May, 13:04 |
| Andrei Budnik |
Re: Review Request 66668: Removed `destroyed` from `Container` struct in composing containerizer. |
Fri, 11 May, 13:52 |
| Andrei Budnik |
Re: Review Request 66817: Enabled composing containerizer as a default containerizer in tests. |
Fri, 11 May, 13:55 |
| Andrei Budnik |
Re: Review Request 66669: Added clean up of `containers_` map in composing containerizer. |
Fri, 11 May, 19:26 |
| Andrei Budnik |
Re: Review Request 66670: Ensured that `wait()` and `destroy()` return the same result. |
Mon, 14 May, 13:23 |
| Andrei Budnik |
Review Request 67128: Removed extra `containerizer->wait()` calls in tests. |
Tue, 15 May, 11:02 |
| Andrei Budnik |
Review Request 67130: Updated comments related to `wait`, `destroy` containerizer methods. |
Tue, 15 May, 13:50 |
| Andrei Budnik |
Review Request 67135: Added test to verify presence of nested container termination status. |
Tue, 15 May, 16:10 |
| Andrei Budnik |
Re: Review Request 66668: Removed `destroyed` from `Container` struct in composing containerizer. |
Wed, 16 May, 14:16 |
| Andrei Budnik |
Re: Review Request 66668: Removed `destroyed` from `Container` struct in composing containerizer. |
Fri, 18 May, 12:25 |
| Andrei Budnik |
Re: Review Request 66668: Removed `destroyed` from `Container` struct in composing containerizer. |
Fri, 18 May, 19:58 |
| Andrei Budnik |
Re: Review Request 66668: Removed `destroyed` from `Container` struct in composing containerizer. |
Tue, 22 May, 15:46 |
| Andrei Budnik |
Re: Review Request 66670: Ensured that `wait()` and `destroy()` return the same result. |
Tue, 22 May, 17:20 |
| Andrei Budnik |
Re: Review Request 66668: Removed `destroyed` from `Container` struct in composing containerizer. |
Tue, 22 May, 18:13 |
| Andrei Budnik |
Re: Review Request 66668: Removed `destroyed` from `Container` struct in composing containerizer. |
Wed, 23 May, 13:31 |
| Andrei Budnik |
Re: Review Request 66668: Removed `destroyed` from `Container` struct in composing containerizer. |
Wed, 23 May, 14:21 |
| Andrei Budnik |
Re: Review Request 66671: Updated composing containerizer tests. |
Wed, 23 May, 15:12 |
| Andrei Budnik |
Review Request 67317: Fixed flaky `TerminatedNestedStatus` test. |
Fri, 25 May, 10:50 |
| Andrei Budnik |
Review Request 67354: Removed `os::getenv()` calls from `MesosExecutorDriver`. |
Tue, 29 May, 14:20 |
| Andrei Budnik |
Review Request 67355: Removed `os::getenv()` calls from `MesosProcess`. |
Tue, 29 May, 14:20 |
| Andrei Budnik |
Review Request 67356: Made `TestContainerizerProcess::launch()` thread safe. |
Tue, 29 May, 14:21 |
| Andrew Schwartzmeyer |
Re: Review Request 66773: Windows: Fixed `os::stat::mtime()` to use `GetFileTime()`. |
Tue, 01 May, 21:14 |
| Andrew Schwartzmeyer |
Re: Review Request 66773: Windows: Fixed `os::stat::mtime()` to use `GetFileTime()`. |
Tue, 01 May, 21:23 |
| Andrew Schwartzmeyer |
Review Request 66892: Added `SubprocessTest.PipeLargeOutput`. |
Tue, 01 May, 21:24 |
| Andrew Schwartzmeyer |
Re: Review Request 66431: Windows: Fixed `os::read()` to use `ReadFile()`. |
Tue, 01 May, 21:24 |
| Andrew Schwartzmeyer |
Re: Review Request 66425: Windows: Replaced `WindowsFD` with `int_fd` typedef. |
Tue, 01 May, 21:32 |
| Andrew Schwartzmeyer |
Re: Review Request 66834: Windows: Specialized `flags::parse<int_fd>`. |
Tue, 01 May, 22:08 |
| Andrew Schwartzmeyer |
Re: Review Request 66790: Windows: Ported the rest of the `SubprocessTest` suite. |
Tue, 01 May, 22:09 |
| Andrew Schwartzmeyer |
Re: Review Request 66790: Windows: Ported the rest of the `SubprocessTest` suite. |
Tue, 01 May, 22:42 |
| Andrew Schwartzmeyer |
Re: Review Request 66834: Windows: Specialized `flags::parse<int_fd>`. |
Tue, 01 May, 22:43 |
| Andrew Schwartzmeyer |
Re: Review Request 66901: Add the ASF events link to the website. |
Wed, 02 May, 16:55 |
| Andrew Schwartzmeyer |
Review Request 66912: Resolved the `realpath` of the sandbox directory in tests. |
Wed, 02 May, 18:29 |
| Andrew Schwartzmeyer |
Re: Review Request 66912: Resolved the `realpath` of the sandbox directory in tests. |
Wed, 02 May, 19:52 |
| Andrew Schwartzmeyer |
Re: Review Request 66916: Disabled a resource provider resubscription test on Windows. |
Wed, 02 May, 19:56 |
| Andrew Schwartzmeyer |
Review Request 66964: Ported (some) Python 2 support scripts to Python 3. |
Fri, 04 May, 20:44 |
| Andrew Schwartzmeyer |
Review Request 66970: Added MESOS-8682 and MESOS-8659 to the 1.6.0 CHANGELOG. |
Fri, 04 May, 21:18 |
| Andrew Schwartzmeyer |
Re: Review Request 66964: Ported (some) Python 2 support scripts to Python 3. |
Fri, 04 May, 22:55 |
| Andrew Schwartzmeyer |
Re: Review Request 66964: Ported (some) Python 2 support scripts to Python 3. |
Fri, 04 May, 23:09 |
| Andrew Schwartzmeyer |
Re: Review Request 66952: Windows: Added overlapped field to WindowsFD. |
Mon, 07 May, 18:54 |