-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67398/#review204113
-----------------------------------------------------------
src/tests/containerizer/nested_mesos_containerizer_tests.cpp
Line 429 (original), 454 (patched)
<https://reviews.apache.org/r/67398/#comment286504>
I still see this test failing in our internal CI, need to investigate what is amiss here.
- Benjamin Bannier
On May 31, 2018, 4:55 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67398/
> -----------------------------------------------------------
>
> (Updated May 31, 2018, 4:55 p.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-8917
> https://issues.apache.org/jira/browse/MESOS-8917
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Some tests of nested container functionality used pipes passed to
> launched tasks to detect whether a task has actually started executing
> the workload (`TASK_RUNNING` updates might be sent before the task
> workload is actually started).
>
> Once we avoid leaking unspecified file descriptors into forked
> processes, this test setup will be broken. In this patch we replace
> the use of pipes for synchronization with HTTP requests to an actor
> running in the tests.
>
>
> Diffs
> -----
>
> src/tests/containerizer/nested_mesos_containerizer_tests.cpp 6050e6ebed87249382d56aedb6d98d3cf9812bb9
>
>
> Diff: https://reviews.apache.org/r/67398/diff/1/
>
>
> Testing
> -------
>
> `sudo make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
|