mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 67365: Added MESOS-8340 to the 1.7.x CHANGELOG.
Date Thu, 31 May 2018 04:15:51 GMT


> On May 30, 2018, 10:56 a.m., Jiang Yan Xu wrote:
> > docs/upgrades.md
> > Lines 445 (patched)
> > <https://reviews.apache.org/r/67365/diff/1/?file=2031690#file2031690line445>
> >
> >     Is it TCP specific?
> 
> James Peach wrote:
>     Yes.

I see and I found the word TCP in code comments. So apps are free to listening on unassigned
UDP ports? This is fine but I am just a bit surprised this is the place in the documentation
that TCP is mentioned (not in network-ports.md either). Worth clarifying (separately as this
RR is about CHANGELOG)?


- Jiang Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67365/#review204058
-----------------------------------------------------------


On May 30, 2018, 11:57 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67365/
> -----------------------------------------------------------
> 
> (Updated May 30, 2018, 11:57 a.m.)
> 
> 
> Review request for mesos, Xudong Ni and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-8340
>     https://issues.apache.org/jira/browse/MESOS-8340
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added MESOS-8340 to the 1.7.x CHANGELOG.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG 52c7fc3bcd73a0eead2934644f636b85c60e0061 
>   docs/upgrades.md 1a1705cd9c38583c591392dd154d136fce04129d 
> 
> 
> Diff: https://reviews.apache.org/r/67365/diff/2/
> 
> 
> Testing
> -------
> 
> Manual inspection of the dev website.
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message