mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <akash-gu...@hotmail.com>
Subject Review Request 67395: Fixed socket creation bug in docker.cpp.
Date Thu, 31 May 2018 02:59:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67395/
-----------------------------------------------------------

Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.


Repository: mesos


Description
-------

On Windows, the statement `int_fd socket = ::socket(...);` would
implictly call the `WindowsFD(int crt)` constructor. Since that
contstructor only accepts values of {0, 1, 2}, it would incorrectly
mark the socket as invalid. The code has been changed to use the stout
network functions, which properly construct the `int_fd`.


Diffs
-----

  src/slave/containerizer/docker.cpp fc032367400119dc827657d0e6e859d18ebdbb16 


Diff: https://reviews.apache.org/r/67395/diff/1/


Testing
-------

This bug was found when testing recovery in our Windows cluster and this patch was confirmed
to fix it.


Thanks,

Akash Gupta


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message