mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 67343: Automatically loaded all the local enabled cgroups subsystems.
Date Thu, 31 May 2018 00:42:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67343/#review204093
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp
Lines 97 (patched)
<https://reviews.apache.org/r/67343/#comment286484>

    one more space before (



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp
Lines 108 (patched)
<https://reviews.apache.org/r/67343/#comment286486>

    enabled cgroup subsystems?



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp
Lines 134 (patched)
<https://reviews.apache.org/r/67343/#comment286487>

    this is not like happen though, but I am thinking if we should return an error and block
the agent in this case?



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp
Lines 137 (patched)
<https://reviews.apache.org/r/67343/#comment286488>

    cgroup subsystems



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp
Lines 163 (patched)
<https://reviews.apache.org/r/67343/#comment286489>

    why not const ref?


- Gilbert Song


On May 30, 2018, 6:05 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67343/
> -----------------------------------------------------------
> 
> (Updated May 30, 2018, 6:05 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-7691
>     https://issues.apache.org/jira/browse/MESOS-7691
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When `cgroups/all` is specified in the agent flag `--isolation`, we
> will automatically load all the local enabled cgroups subsystems in
> the cgroups isolator with one exception: the `perf_event` subsystem,
> we will only automatically load it when the agent flag `--perf_events`
> is specified, otherwise it will be skipped.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp 93197b05eb837d02c6c113264f20a33d6ed92d7f

>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 6d663a5770418b7ffe2b3af50b9181ecde183c67

> 
> 
> Diff: https://reviews.apache.org/r/67343/diff/3/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message