mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 67342: Added `cgroups/all` into the agent flag `--isolation`.
Date Thu, 31 May 2018 00:00:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67342/#review204092
-----------------------------------------------------------



Could we also update the mesos-containerizer.md and have a new file to introduce the semantic,
since people may rely on that document as reference.


docs/configuration/agent.md
Line 1033 (original), 1033 (patched)
<https://reviews.apache.org/r/67342/#comment286481>

    Should we mention the overwrite semantic?



docs/configuration/agent.md
Line 1034 (original), 1034 (patched)
<https://reviews.apache.org/r/67342/#comment286478>

    s/in/on/g?



docs/configuration/agent.md
Lines 1035 (patched)
<https://reviews.apache.org/r/67342/#comment286479>

    s/in/by/g?



src/slave/flags.cpp
Line 132 (original), 132-133 (patched)
<https://reviews.apache.org/r/67342/#comment286480>

    ditto.


- Gilbert Song


On May 30, 2018, 6:04 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67342/
> -----------------------------------------------------------
> 
> (Updated May 30, 2018, 6:04 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-7691
>     https://issues.apache.org/jira/browse/MESOS-7691
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added `cgroups/all` into the agent flag `--isolation`.
> 
> 
> Diffs
> -----
> 
>   docs/configuration/agent.md e0aaf2c15023d1cb24e16b02f948b3d3848be57a 
>   src/slave/flags.cpp 23d9bb1ca9bc7451afae69f39c25605660612c2e 
> 
> 
> Diff: https://reviews.apache.org/r/67342/diff/2/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message