mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 67274: Rejected non-zero scalar resource values which be represented as zero.
Date Wed, 30 May 2018 23:41:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67274/#review204088
-----------------------------------------------------------



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67274']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67274

Relevant logs:

- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67274/logs/mesos-tests-stdout.log):

```
[       OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (109 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (1044 ms total)

[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN      ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[       OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (32 ms)
[ RUN      ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[       OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (37 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (71 ms total)

[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN      ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[       OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (737 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (761 ms total)

[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN      ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[       OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (736 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (761 ms total)

[----------] Global test environment tear-down
[==========] 981 tests from 95 test cases ran. (435275 ms total)
[  PASSED  ] 980 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] MesosContainerizer/DefaultExecutorTest.SigkillExecutor/0, where GetParam() =
"mesos"

 1 FAILED TEST
  YOU HAVE 220 DISABLED TESTS

```

- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67274/logs/mesos-tests-stderr.log):

```
I0530 23:41:18.983530 10612 master.cpp:10843] Updating the state of task c98e68bc-5291-471e-b746-4e5ed551423d
of framework e8cbc913-a4ec-451f-a433-1112c7ed1fdf-0000 (latest state: TASK_KILLED, status
update state: TASK_KILLED)
I0530 23:41:18.983530 19536 slave.cpp:3935] Shutting down framework e8cbc913-a4ec-451f-a433-1112c7ed1fdf-0000
I0530 23:41:18.984529 19536 slave.cpp:6656] Shutting down executor 'c98e68bc-5291-471e-b746-4e5ed551423d'
of framework e8cbc913-a4ec-451f-a433-1112c7ed1fdf-0000 at executor(1)@192.10.1.6:56078
I0530 23:41:18.985555 19536 slave.cpp:929] Agent terminating
W0530 23:41:18.985555 19536 slave.cpp:3931] Ignoring shutdown framework e8cbc913-a4ec-451f-a433-1112c7ed1fdf-0000
because it is terminating
I0530 23:41:18.986522 10612 master.cpp:10942] Removing task c98e68I0530 23:41:18.819555 17288
exec.cpp:162] Version: 1.7.0
I0530 23:41:18.847556    32 exec.cpp:236] Executor registered on agent e8cbc913-a4ec-451f-a433-1112c7ed1fdf-S0
I0530 23:41:18.851557 22108 executor.cpp:178] Received SUBSCRIBED event
I0530 23:41:18.856546 22108 executor.cpp:182] Subscribed executor on windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net
I0530 23:41:18.856546 22108 executor.cpp:178] Received LAUNCH event
I0530 23:41:18.861564 22108 executor.cpp:665] Starting task c98e68bc-5291-471e-b746-4e5ed551423d
I0530 23:41:18.943548 22108 executor.cpp:485] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe
launch <POSSIBLY-SENSITIVE-DATA>'
I0530 23:41:18.955543 22108 executor.cpp:678] Forked command at 9304
I0530 23:41:18.985555 15776 exec.cpp:445] Executor asked to shutdown
I0530 23:41:18.986522 20252 executor.cpp:178] Received SHUTDOWN event
I0530 23:41:18.986522 20252 executor.cpp:781] Shutting down
I0530 23:41:18.986522 20252 executor.cpp:894] Sending SIGTERM to process tree at pid 930bc-5291-471e-b746-4e5ed551423d
with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated:
*):[31000-32000] of framework e8cbc913-a4ec-451f-a433-1112c7ed1fdf-0000 on agent e8cbc913-a4ec-451f-a433-1112c7ed1fdf-S0
at slave(447)@192.10.1.6:56057 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0530 23:41:18.989536 10612 master.cpp:1293] Agent e8cbc913-a4ec-451f-a433-1112c7ed1fdf-S0
at slave(447)@192.10.1.6:56057 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
disconnected
I0530 23:41:18.989536 10612 master.cpp:3303] Disconnecting agent e8cbc913-a4ec-451f-a433-1112c7ed1fdf-S0
at slave(447)@192.10.1.6:56057 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0530 23:41:18.989536 10612 master.cpp:3322] Deactivating agent e8cbc913-a4ec-451f-a433-1112c7ed1fdf-S0
at slave(447)@192.10.1.6:56057 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0530 23:41:18.990536 16884 hierarchical.cpp:344] Removed framework e8cbc913-a4ec-451f-a433-1112c7ed1fdf-0000
I0530 23:41:18.990536 21804 containerizer.cpp:2406] Destroying container dfc82f40-49b2-4aa4-9ce7-aa3a5f31f056
in RUNNING state
I0530 23:41:18.991535 21804 containerizer.cpp:3020] Transitioning the state of container dfc82f40-49b2-4aa4-9ce7-aa3a5f31f056
from RUNNING to DESTROYING
I0530 23:41:18.991535 16884 hierarchical.cpp:766] Agent e8cbc913-a4ec-451f-a433-1112c7ed1fdf-S0
deactivated
I0530 23:41:18.991535 21804 launcher.cpp:156] Asked to destroy container dfc82f40-49b2-4aa4-9ce7-aa3a5f31f056
I0530 23:41:19.065137  8636 containerizer.cpp:2859] Container dfc82f40-49b2-4aa4-9ce7-aa3a5f31f056
has exited
I0530 23:41:19.094125 15044 master.cpp:1135] Master terminating
I0530 23:41:19.096104 21964 hierarchical.cpp:609] Removed agent e8cbc913-a4ec-451f-a433-1112c7ed1fdf-S0
I0530 23:41:19.552120 21472 process.cpp:940] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On May 30, 2018, 2:50 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67274/
> -----------------------------------------------------------
> 
> (Updated May 30, 2018, 2:50 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, Michael Park, and Neil Conway.
> 
> 
> Bugs: MESOS-8945
>     https://issues.apache.org/jira/browse/MESOS-8945
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Internally values of scalar resources are stored in a fixed point
> representation. This can lead to (expected) precision loss.
> 
> This patch updates the resource validation ensuring that values of
> scalar resources are either zero or large enough so that they are
> still represented as non-zero values after conversion to the internal
> fixed point format. With that we can still parse resources containing
> resource values explictly set to zero to be able to distinguish empty
> and abset resources, but prevent propagation of values accidentially
> rounded to an effectively empty result.
> 
> While this patch should not change valid, intended use cases, it might
> change the behavior for erroneous, already broken framework workflows.
> 
> 
> Diffs
> -----
> 
>   src/common/resources.cpp 192d086e60b81c0ae8e26d4120beee2034f63d3e 
>   src/tests/master_tests.cpp 6efcbd12902de32428cb7f23ed0d3967a18f749d 
>   src/tests/resources_tests.cpp 1201efec3ff0abc268f896c1fe2330571390b3fd 
> 
> 
> Diff: https://reviews.apache.org/r/67274/diff/5/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message