mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 67309: Updated Future::select to take any iterable type.
Date Wed, 30 May 2018 19:48:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67309/#review204066
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/libprocess/include/process/future.hpp
Line 994 (original), 994 (patched)
<https://reviews.apache.org/r/67309/#comment286458>

    This patch seems to affect `process::discard` instead of `Future::select`. Is there a
mistake in the summary?


- Chun-Hung Hsiao


On May 25, 2018, 2:56 a.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67309/
> -----------------------------------------------------------
> 
> (Updated May 25, 2018, 2:56 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/future.hpp b8508c5018d71885ecb7d239d72c51d8af2dfc19

> 
> 
> Diff: https://reviews.apache.org/r/67309/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message