mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <akash-gu...@hotmail.com>
Subject Review Request 67386: Added `io::prepare_async` and `io::is_async` functions for libprocess.
Date Wed, 30 May 2018 18:56:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67386/
-----------------------------------------------------------

Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, John Kordich,
Joseph Wu, and Radhika Jandhyala.


Bugs: MESOS-5371 and MESOS-8668
    https://issues.apache.org/jira/browse/MESOS-5371
    https://issues.apache.org/jira/browse/MESOS-8668


Repository: mesos


Description
-------

`os::nonblock` and `os::isNonBlock` are stubs that only do things for
Windows sockets. For the IOCP implementation, we need to associate the
handles with the IOCP hande, which is created by libprocess. Thus, we
need these new functions to prepare the handle for the async IO
functions by either setting the hande to non-blocking on UNIX systems
or by associating it with an IOCP handle on Windows.


Diffs
-----

  3rdparty/libprocess/include/process/io.hpp cc2caf44e065bed40263f3820e95a4f7c378bb98 
  3rdparty/libprocess/src/io.cpp 97f2b17092fbd23528cf3220fee5927a1ec38aba 
  3rdparty/libprocess/src/socket.cpp 504cb541785650d2d05aabd25f5258b9bad52baa 
  3rdparty/libprocess/src/tests/subprocess_tests.cpp 568d77b94b3afef8c1ebdde71e14aa0b498da5c8



Diff: https://reviews.apache.org/r/67386/diff/1/


Testing
-------


Thanks,

Akash Gupta


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message