mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <akash-gu...@hotmail.com>
Subject Review Request 67392: Windows: Made PipeLargeOutput test work with IOCP backend.
Date Wed, 30 May 2018 18:41:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67392/
-----------------------------------------------------------

Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, John Kordich,
Joseph Wu, and Radhika Jandhyala.


Bugs: MESOS-8668
    https://issues.apache.org/jira/browse/MESOS-8668


Repository: mesos


Description
-------

THe PipeLargeOutput test was calling `io::read`, which was returning the
wrong error since it operates at a higher level abstraction. The test
really just checks if a pipe EOF returns `ERROR_BROKEN_PIPE`, so the
test was changed to use the lower level `os::read`.


Diffs
-----

  3rdparty/libprocess/src/tests/subprocess_tests.cpp 568d77b94b3afef8c1ebdde71e14aa0b498da5c8



Diff: https://reviews.apache.org/r/67392/diff/1/


Testing
-------


Thanks,

Akash Gupta


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message