mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Radhika Jandhyala via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 67288: White list fds that child processes can inherit in stout.
Date Wed, 30 May 2018 07:04:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67288/
-----------------------------------------------------------

(Updated May 30, 2018, 7:04 a.m.)


Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Eric Mumau, Jie Yu, Li Li, and
Radhika Jandhyala.


Summary (updated)
-----------------

White list fds that child processes can inherit in stout.


Bugs: MESOS-8926
    https://issues.apache.org/jira/browse/MESOS-8926


Repository: mesos


Description (updated)
-------

Review: https://reviews.apache.org/r/67286

White list fds that child processes can inherit in libprocess.

Review: https://reviews.apache.org/r/67287

Whitelist fds in mesos containerizer.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/subprocess.hpp 6a1262340c333b617402637e648c12769827ffc4

  3rdparty/libprocess/src/subprocess.cpp d7a725363251f9c54072cd7551f5598696938308 
  3rdparty/libprocess/src/subprocess_windows.hpp c7ed0ad18f5b46a1d5ac2a6e51883aefb7c1692f

  3rdparty/stout/include/stout/internal/windows/inherit.hpp 7dbde820e775cbaeb8db4bc4559ab432903e75ea

  3rdparty/stout/include/stout/os/windows/shell.hpp 8da612af2888ff4d4d458ea5b16cdb08779b6f4c

  src/slave/containerizer/mesos/containerizer.cpp eac1d16f2388385fec04ff8f013ce0ebf4e97f0f

  src/slave/containerizer/mesos/launcher.hpp f69d934d2e1a129e10df8c7f5c78723e832adc7d 
  src/slave/containerizer/mesos/launcher.cpp 2fe47d368cb82a46328e1f636baa836272db244c 
  src/slave/containerizer/mesos/linux_launcher.hpp 0ea9b875ae46cadea483bc8dd8bf4907fd324dc9

  src/slave/containerizer/mesos/linux_launcher.cpp 80e444501e429c1e1ae354abcd51f86430316ada

  src/tests/containerizer/launcher.hpp a8e436f164b67d937ebcff35e084d3ca755c003c 
  src/tests/containerizer/launcher.cpp a92d9890f0931425d69ef8ce0896d081b8722079 
  src/tests/containerizer/mesos_containerizer_tests.cpp 01f2b38cfa67b144298c361e92170322864ac201



Diff: https://reviews.apache.org/r/67288/diff/3/

Changes: https://reviews.apache.org/r/67288/diff/2-3/


Testing
-------


Thanks,

Radhika Jandhyala


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message