mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Review Request 67371: Introduced a random sorter as an alternative to the DRF sorter.
Date Wed, 30 May 2018 01:00:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67371/
-----------------------------------------------------------

Review request for mesos, Gaston Kleiman, Greg Mann, and Meng Zhu.


Bugs: MESOS-8936
    https://issues.apache.org/jira/browse/MESOS-8936


Repository: mesos


Description
-------

This sorter returns a weighted random shuffling of its clients
upon each `sort()` request.

This implementation is a copy of the `DRFSorter` with share
calculation logic (including the `dirty` bit) removed and an
adjusted `sort()` implementation. Work needs to be done to
reduce the amount of duplicated logic needed across sorter
implementations, but it is left unaddressed here.


Diffs
-----

  src/Makefile.am b7184ceccef5f2e985d905c155156f95c7a7c7b4 
  src/master/allocator/sorter/random/sorter.hpp PRE-CREATION 
  src/master/allocator/sorter/random/sorter.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/67371/diff/1/


Testing
-------

Unit tests added in subsequent patch.


Thanks,

Benjamin Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message