mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 67363: Switched test devices for the `linux/devices` isolator tests.
Date Wed, 30 May 2018 00:37:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67363/#review204024
-----------------------------------------------------------



Patch looks great!

Reviews applied: [67362, 67363]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On May 29, 2018, 1:36 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67363/
> -----------------------------------------------------------
> 
> (Updated May 29, 2018, 1:36 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Jie Yu.
> 
> 
> Bugs: MESOS-8958
>     https://issues.apache.org/jira/browse/MESOS-8958
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `cpuid` device is not always available when running tests
> in a VM, so switch to `/dev/net/tun`. For the purposes of this
> test, is doesn't matter what the device is as long as it is
> in a subdirectory.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/linux_devices_isolator_tests.cpp efaa43b8b7b7c73c35d995bfbb81fcd620143ea1

> 
> 
> Diff: https://reviews.apache.org/r/67363/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check (Fedora 27)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message