mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.
Date Tue, 29 May 2018 20:53:23 GMT


> On May 29, 2018, 1:38 p.m., John Kordich wrote:
> > I'm not sure why review bot is failing for Linux. Will investigate. Seems to build
just fine for me.

You probably need to add any new stout headers to the Makefile(s).  The `distcheck` won't
pick up headers automatically.


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67066/#review204009
-----------------------------------------------------------


On May 24, 2018, 7:13 p.m., John Kordich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67066/
> -----------------------------------------------------------
> 
> (Updated May 24, 2018, 7:13 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, Eric Mumau,
Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8064
>     https://issues.apache.org/jira/browse/MESOS-8064
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Modified the fetcher to use libarchive and added associated tests.
> 
> 
> Diffs
> -----
> 
>   src/launcher/fetcher.cpp 4cff7273fdc9e3897074da4da7dad02483086c2d 
>   src/tests/fetcher_tests.cpp 95359ec84ed631bdd7b4fb5192e03f68cc57ed61 
> 
> 
> Diff: https://reviews.apache.org/r/67066/diff/6/
> 
> 
> Testing
> -------
> 
> I've built on Windows with CMake and have run all tests, which all pass.
> I've also built on Linux with both the autotools build and cmake build and have run all
tests, which all pass.
> 
> 
> Thanks,
> 
> John Kordich
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message