mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Review Request 67362: Updated `linux/devices` isolator tests for compiler compatibility.
Date Tue, 29 May 2018 20:20:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67362/
-----------------------------------------------------------

Review request for mesos and Alexander Rukletsov.


Repository: mesos


Description
-------

The `linux/devices` isolator tests fail to build on on
Ubuntu 14.04 with `gcc (Ubuntu 4.8.4-2ubuntu1~14.04.4)
4.8.4` due to what seems to me a compiler bug, possibly
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57824.

Work around any compiler issues by defining the test cases
in a separate vector so that the copmiler doesn't have any
raw strings in the macro expansion.


Diffs
-----

  src/tests/containerizer/linux_devices_isolator_tests.cpp efaa43b8b7b7c73c35d995bfbb81fcd620143ea1



Diff: https://reviews.apache.org/r/67362/diff/1/


Testing
-------

sudo make check (Fedora 27)


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message