mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Review Request 67355: Removed `os::getenv()` calls from `MesosProcess`.
Date Tue, 29 May 2018 14:20:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67355/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov, Benjamin Bannier, haosdent huang, Ilya Pronin,
and James Peach.


Bugs: MESOS-3475
    https://issues.apache.org/jira/browse/MESOS-3475


Repository: mesos


Description
-------

This patch adds overloaded constructor for `v1::executor::Mesos` class
that accepts `environment` parameter that is passed over to
`MesosProcess` constructor. This change is needed to get rid of
`os::getenv()` calls, so that v1 Executor can be used in tests that
require thread safety.


Diffs
-----

  include/mesos/v1/executor.hpp ca48f29483f3f5caeb070f33d009ab89c9f4829b 
  src/executor/executor.cpp 5e95f999535a81bf6873144a83d520897b3cdc8a 
  src/tests/mesos.hpp 733344a2f07ebd9d841a55fb9bbfda2e3c1a1eb2 


Diff: https://reviews.apache.org/r/67355/diff/1/


Testing
-------

internal CI


Thanks,

Andrei Budnik


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message