mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Review Request 67354: Removed `os::getenv()` calls from `MesosExecutorDriver`.
Date Tue, 29 May 2018 14:20:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67354/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov, Benjamin Bannier, haosdent huang, Ilya Pronin,
and James Peach.


Bugs: MESOS-3475
    https://issues.apache.org/jira/browse/MESOS-3475


Repository: mesos


Description
-------

This patch adds overloaded constructor for `MesosExecutorDriver` that
accepts `environment` parameter and stores it in the class variable.
This new constructor is needed to get rid of `os::getenv()` calls,
so that `MesosExecutorDriver` can be used in tests that require
thread safety.


Diffs
-----

  include/mesos/executor.hpp d14c0369f6731100d27092142b56f108f8881003 
  src/exec/exec.cpp 65a671d7ce83a51087d290ba039d18deba6313c2 


Diff: https://reviews.apache.org/r/67354/diff/1/


Testing
-------

internal CI


Thanks,

Andrei Budnik


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message