mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 67270: Fixed compilation issues in libprocess example.
Date Tue, 29 May 2018 13:46:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67270/
-----------------------------------------------------------

(Updated May 29, 2018, 1:46 p.m.)


Review request for mesos and Benjamin Mahler.


Repository: mesos


Description (updated)
-------

* Added the mandatory help string argument to calls
  to 'route()', failing compilation.

* The response returned from the '/vars' endpoint had
  its 'type' field set to 'NONE', causing indefinite
  hanging when trying to access the endpoint. Switched
  to a constructor for OK that implicitly sets that field.

* Removed a stray pid variable in main.

* Added http:: namespace to disambiguate calls to 'post()'.

* Added a name to the example process.

* Commented out example code that commits instant
  self-termination by default.


Diffs (updated)
-----

  3rdparty/libprocess/examples/example.cpp a97665ee6b75c5b31397b5a10002fa23a7fe370a 


Diff: https://reviews.apache.org/r/67270/diff/5/

Changes: https://reviews.apache.org/r/67270/diff/4-5/


Testing
-------

Compiled the `example.cpp` file.


Thanks,

Benno Evers


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message