mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 67270: Fixed compilation issues in libprocess example.
Date Tue, 29 May 2018 10:39:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67270/#review203974
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Bannier


On May 24, 2018, 3:33 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67270/
> -----------------------------------------------------------
> 
> (Updated May 24, 2018, 3:33 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> * Added the mandatory help string argument to calls
>   to 'route()', failing compilation.
> 
> * The response returned from the '/vars' endpoint had
>   its 'type' field set to 'NONE', causing indefinite
>   hanging when trying to access the endpoint. Switched
>   to a constructor for OK that implicitly sets that field.
> 
> * Removed a stray pid variable in main.
> 
> * Added http:: namespace to disambiguate calls to 'post()'.
> 
> * Commented out example code that commits instant
>   self-termination by default.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/examples/example.cpp 8c507aefa050543dfa6184626c494918c96d35e7 
> 
> 
> Diff: https://reviews.apache.org/r/67270/diff/4/
> 
> 
> Testing
> -------
> 
> Compiled the `example.cpp` file.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message