mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 67340: Fixed python3/mesos-style.py type error.
Date Tue, 29 May 2018 09:47:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67340/#review203972
-----------------------------------------------------------


Ship it!




Ship It!

- Alexander Rukletsov


On May 28, 2018, 1:16 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67340/
> -----------------------------------------------------------
> 
> (Updated May 28, 2018, 1:16 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-8954
>     https://issues.apache.org/jira/browse/MESOS-8954
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The main challenge when switching from Python 2 to Python 3 is
> to handle the strings, as many of them are now byte strings. I
> have checked the other uses of `sys.stderr.write` while working
> on this commit to check that it was the last issue of that type
> in python3/mesos-style.py.
> 
> 
> Diffs
> -----
> 
>   support/python3/mesos-style.py c0e918c611020a4dbba4c65bd4ac849a716f63e2 
> 
> 
> Diff: https://reviews.apache.org/r/67340/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message