mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Review Request 67345: Removed unchecked access to an optional in checker process.
Date Mon, 28 May 2018 16:01:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67345/
-----------------------------------------------------------

Review request for mesos and Alexander Rukletsov.


Bugs: MESOS-8963
    https://issues.apache.org/jira/browse/MESOS-8963


Repository: mesos


Description
-------

This could lead to an excutor crash when the id was set to None
between the check and the time it was accessed.


Diffs
-----

  src/checks/checker_process.cpp c37a329dc2fabf365320d1735a4c5defafb348a7 


Diff: https://reviews.apache.org/r/67345/diff/1/


Testing
-------

`make check`

(Note that I don't know how to write a unit test for this; suggestions are welcome)


Thanks,

Benno Evers


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message