mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Review Request 67339: Modified launch.cpp to writes its logs into cerr.
Date Mon, 28 May 2018 10:37:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67339/
-----------------------------------------------------------

Review request for mesos and Alexander Rukletsov.


Repository: mesos


Description
-------

`containerizer/mesos/launch.cpp` wrote some of its output into
`cout` and some into `cerr` without a clear distinction as to
why it was done in some cases.

Moreover, it is standard for logging utilities to write their
output into cerr, and finally in Mesos clog should probably
kept clean for the task output in cases there consumers of the
task which process the cout of it.


Diffs
-----

  src/slave/containerizer/mesos/launch.cpp 70b7805f88e6475992bc8408024eba78d01e341d 


Diff: https://reviews.apache.org/r/67339/diff/1/


Testing
-------

```sh
make check
```


Thanks,

Alexander Rojas


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message