mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 67224: Combined and renamed `csi_*_plugin_terminations` metrics.
Date Fri, 25 May 2018 22:11:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67224/#review203910
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On May 24, 2018, 12:47 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67224/
> -----------------------------------------------------------
> 
> (Updated May 24, 2018, 12:47 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> To avoid double counting when the operator aggregates the
> `csi_controller_plugin_terminations` and `csi_node_plugin_terminations`,
> these two are now merged into `csi_plugin/container_terminations`.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/storage/provider.cpp 63b5d7e5f10d6ad02b5cd11b119def3b4abf4180

>   src/tests/storage_local_resource_provider_tests.cpp 45cb38922f78941e82667a60b3b71ce220c9202f

> 
> 
> Diff: https://reviews.apache.org/r/67224/diff/3/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message