mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 67320: Sent task (health) check updates over the operator streaming API.
Date Fri, 25 May 2018 16:18:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67320/#review203885
-----------------------------------------------------------




src/tests/api_tests.cpp
Lines 2386 (patched)
<https://reviews.apache.org/r/67320/#comment286238>

    We typically do not do `this->`.
    
    `Try<Owned<cluster::Master>> master = StartMaster();`


- Zhitao Li


On May 25, 2018, 6:52 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67320/
> -----------------------------------------------------------
> 
> (Updated May 25, 2018, 6:52 a.m.)
> 
> 
> Review request for mesos and Zhitao Li.
> 
> 
> Bugs: MESOS-8942
>     https://issues.apache.org/jira/browse/MESOS-8942
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> With this patch subscribers to the master operator streaming API
> start receiving task health (check) updates. This allows subscribers
> to maintain more accurate view of the cluster's state, closer to
> what the traditional `state.json` endpoint offers.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e 
>   src/tests/api_tests.cpp 84368707e2c0bcf66bbfb308a4b863112119d328 
> 
> 
> Diff: https://reviews.apache.org/r/67320/diff/1/
> 
> 
> Testing
> -------
> 
> make check on
> * Mac OS 10.13.4
> * various linux distros
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message