mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 67270: Fixed compilation issues in libprocess example.
Date Fri, 25 May 2018 15:55:46 GMT


> On May 25, 2018, 3:37 p.m., Benjamin Bannier wrote:
> > 3rdparty/libprocess/examples/example.cpp
> > Line 106 (original), 98 (patched)
> > <https://reviews.apache.org/r/67270/diff/4/?file=2028088#file2028088line113>
> >
> >     If you add this and the one below you should remove the `using` decl for `process::http`
on top.
> >     
> >     Or just leave this as it was for now.

The `process::http` using declaration is used for much more, e.g. `Response`, `Request`, etc.
It's only added where required to disambiguate from functions with the same name in another
namespace. I believe that's fairly standard practice?

I can remove it if you want, but then I'd probably prefer to remove the `using namespace process`
as well, to be consistent.


> On May 25, 2018, 3:37 p.m., Benjamin Bannier wrote:
> > 3rdparty/libprocess/examples/example.cpp
> > Lines 128-129 (original), 120-121 (patched)
> > <https://reviews.apache.org/r/67270/diff/4/?file=2028088#file2028088line135>
> >
> >     Without this `main` does nothing useful anymore, let's leave this in for now.

On the contrary, it runs a working HTTP server. If it's not commented out, `main` immediately
commits suicide, which imho hardly qualifies as "doing something useful".


- Benno


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67270/#review203886
-----------------------------------------------------------


On May 24, 2018, 1:33 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67270/
> -----------------------------------------------------------
> 
> (Updated May 24, 2018, 1:33 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> * Added the mandatory help string argument to calls
>   to 'route()', failing compilation.
> 
> * The response returned from the '/vars' endpoint had
>   its 'type' field set to 'NONE', causing indefinite
>   hanging when trying to access the endpoint. Switched
>   to a constructor for OK that implicitly sets that field.
> 
> * Removed a stray pid variable in main.
> 
> * Added http:: namespace to disambiguate calls to 'post()'.
> 
> * Commented out example code that commits instant
>   self-termination by default.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/examples/example.cpp 8c507aefa050543dfa6184626c494918c96d35e7 
> 
> 
> Diff: https://reviews.apache.org/r/67270/diff/4/
> 
> 
> Testing
> -------
> 
> Compiled the `example.cpp` file.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message