mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 67312: Updated mesos to use vector instead of list where possible.
Date Fri, 25 May 2018 13:53:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67312/#review203875
-----------------------------------------------------------



Patch looks great!

Reviews applied: [67309, 67310, 67311, 67312]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On May 25, 2018, 3:04 a.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67312/
> -----------------------------------------------------------
> 
> (Updated May 25, 2018, 3:04 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This needs to be done due to the updates to collect and await
> as well as hashmap and LinkedHashmap.
> 
> Other locations were updated as well since this was done as
> a sweep.
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/isolator.hpp f682e3037523b1c210b5ba36246556518f261e1b 
>   src/common/http.cpp 0098c140cb196af78de37183b8b6bdbd4bd24b8d 
>   src/docker/docker.hpp 3c2ab6afa51ad16d2dcf3392f693fb7c2084982e 
>   src/docker/docker.cpp d000a902f1acefa37adc28b2e21a9af59438cbc7 
>   src/hook/manager.cpp 44c0c323fe696c8db8a7d1f57db5528723cfc9d9 
>   src/launcher/default_executor.cpp 76c61068c7acdc7a2eaf59d6ba8308450925c72d 
>   src/linux/cgroups.cpp 847f1167ec3920ff38cf29033f5fe9975bddc294 
>   src/linux/ns.cpp 64722c785cecce5b861efbc3f3f2027a61f666d4 
>   src/log/network.hpp 4aef8b3d915af18256ac471297a98dffac138377 
>   src/master/master.hpp 5ec764b5c7f96bab786084cccf20fd8a17319718 
>   src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e 
>   src/master/quota_handler.cpp 21bafd0064e9397f88185eaf687a58f85da94e2c 
>   src/master/weights_handler.cpp 1053652804a8fc6af31a3b8a9f632f836c897fa9 
>   src/resource_provider/manager.cpp aff1ca52186dceb9d85d17f6699e9760b497cd55 
>   src/slave/containerizer/composing.cpp 7144ba7596a12ad5a16a9fbe7a9164339bdaccd5 
>   src/slave/containerizer/docker.hpp 6bdf4c7f60384473927de437a061fafe94170557 
>   src/slave/containerizer/docker.cpp fc032367400119dc827657d0e6e859d18ebdbb16 
>   src/slave/containerizer/fetcher.cpp 7de57c21c55bc145a78d401bb4224322501c040b 
>   src/slave/containerizer/mesos/containerizer.hpp 22405e67fdcad1734360db5bbac85a298f1482b4

>   src/slave/containerizer/mesos/containerizer.cpp 6620e94718f6bd90be7a94a39a77d1f15987b03e

>   src/slave/containerizer/mesos/io/switchboard.hpp 8a16b1529eceb08723cf0a320f4c8db6425499c2

>   src/slave/containerizer/mesos/io/switchboard.cpp 17e8745701777bf6c13b777c1b91cf861eef2455

>   src/slave/containerizer/mesos/isolator.hpp b7af3946155e28d80013a650973ae230de7d01c5

>   src/slave/containerizer/mesos/isolator.cpp 7a32936b934610f6b086f4434d4f2d56df2cc857

>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp f47b16ea781458f05a1d8fec47b7f972a3251edb

>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 6d663a5770418b7ffe2b3af50b9181ecde183c67

>   src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.hpp 1d49cef6611730bfcca1cc01d4076f5d787f383b

>   src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp 33dd6d98b3cb7fe70a94cdecdd89a136d494b869

>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 0e1761d44f7dce51bef138c5eda2ac3d8eb6ea21

>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp fd86ad13ce6706e2fbc67973cc897729ee18b6f3

>   src/slave/containerizer/mesos/isolators/environment_secret.cpp 77c1ba548ca47be0a7fbb55e141962a1b5a4842c

>   src/slave/containerizer/mesos/isolators/filesystem/linux.hpp 99a6f0daaa55ab471473fb94e726cac607b2e187

>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 284432753dcc834d9a12d9505b3de1acd282bc7b

>   src/slave/containerizer/mesos/isolators/filesystem/posix.hpp 794b6e5990db5f8eb21a6535872f284ca02e0553

>   src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 9ac41af88abb8e95ee0710204c17e2468c2dc7f6

>   src/slave/containerizer/mesos/isolators/gpu/isolator.hpp 5d1bc7bc637fb266018ba89e668910ef7f89d5e8

>   src/slave/containerizer/mesos/isolators/gpu/isolator.cpp f5e8860cc3ce3dcd6d4d15ccfd1cc690484b1b57

>   src/slave/containerizer/mesos/isolators/network/cni/cni.hpp ea5397db95b4fd9747f575ec7c110b1c58cb6eb3

>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 6905cd65e09f5b4f5a9c7663b2a47d9862cff467

>   src/slave/containerizer/mesos/isolators/posix.hpp f70a86cbfda07e6be865d19956015e8e3cf41107

>   src/slave/containerizer/mesos/isolators/posix/disk.hpp 61e414a0b2491b7c99e9958b1605d70fdf3c8b79

>   src/slave/containerizer/mesos/isolators/posix/disk.cpp a3bb74665192f476a35837eb0a32d105c5ebc409

>   src/slave/containerizer/mesos/isolators/volume/image.hpp 54af40c8f5fbd98bd39eae87713ab7d49cf968ba

>   src/slave/containerizer/mesos/isolators/volume/image.cpp 631553e2f61a1b95dd93d333b547ff237f65f59e

>   src/slave/containerizer/mesos/isolators/volume/sandbox_path.hpp 75bb5df9c0114c61fb3b2a5815193783062b2cb2

>   src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp e0cae1036e2e49b4f61705c77f31ae166d1b1380

>   src/slave/containerizer/mesos/isolators/volume/secret.cpp d1bc7c517b4266da177750f503beaacb19d9c6d7

>   src/slave/containerizer/mesos/launcher.hpp f69d934d2e1a129e10df8c7f5c78723e832adc7d

>   src/slave/containerizer/mesos/launcher.cpp 2fe47d368cb82a46328e1f636baa836272db244c

>   src/slave/containerizer/mesos/linux_launcher.hpp 0ea9b875ae46cadea483bc8dd8bf4907fd324dc9

>   src/slave/containerizer/mesos/linux_launcher.cpp 80e444501e429c1e1ae354abcd51f86430316ada

>   src/slave/containerizer/mesos/provisioner/appc/store.cpp f30c166f7b7b1d9a2d5d13a2da534d84a18a5c1c

>   src/slave/containerizer/mesos/provisioner/backends/copy.cpp c48e93f7fd60e61908195d687fecb25fb10b9830

>   src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 5ce49ac396b03e8b6d87601ecaa0691d88de21e3

>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 693e8415b3cf791f26b8f7175df5c9a36dd4c234

>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 8b3f07f5027cb90d4b4ed401960494709d3eda5f

>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 88d701964c019ab1475c92a04f2a27cd025aee2f

>   src/slave/containerizer/mesos/provisioner/provisioner.cpp b3ed4fff9f85cec877b87b250505f5b43a82cfff

>   src/slave/http.cpp 9e4525b321a74ca788a41e88f9f54fd5f4fb18eb 
>   src/slave/slave.hpp 4a3d0145947420359eeabb9a9476a17e29cacaa8 
>   src/slave/slave.cpp 1f77bccd95a05b9f2fb6bd7f0d273ba5dba1fade 
>   src/tests/containerizer/docker_containerizer_tests.cpp ab00d6df9f6e4aa8c7097d66a58b958c14f5c68a

>   src/tests/containerizer/docker_tests.cpp 622ffffc7296b56cef672078ad97d8b93adf3c86 
>   src/tests/containerizer/isolator.hpp f31cf6d141af752f8165e52ca7472c543f568d92 
>   src/tests/containerizer/launcher.hpp a8e436f164b67d937ebcff35e084d3ca755c003c 
>   src/tests/fetcher_cache_tests.cpp 98aae20afb03bd62dc79baf03118b965965ab7be 
>   src/tests/health_check_tests.cpp 7e8f86c903dfad73c2102eaf491fb2adcb7c11cf 
>   src/tests/hook_tests.cpp 26394d83d4aaaea4a250097ae80be17a1462718c 
>   src/tests/master_benchmarks.cpp 80de24da86010e1f04026dfd05706a295b74cbd8 
>   src/tests/mock_docker.hpp 65bc00460dd93157c21cd7ed65403886f17b282f 
>   src/tests/mock_slave.hpp bb0327a72f6c28064788406901778ecde4ca0f69 
>   src/tests/mock_slave.cpp 41bce32c8957cd3846f1ccd6b6af41b7b8d3dd2c 
>   src/tests/slave_tests.cpp 068eb5e361b89b07e3ab9c63aa48b82bd386976c 
>   src/uri/fetchers/docker.cpp 94bbdee3a396ba7a14de609241b78b1579371738 
> 
> 
> Diff: https://reviews.apache.org/r/67312/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message