mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 67313: Windows: Fixed `ROOT_DOCKER_DockerHealthStatusChange` test.
Date Fri, 25 May 2018 03:27:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67313/#review203843
-----------------------------------------------------------


Ship it!




Brilliant find.

First question that came to my mind was: why, then, did it work under a debugger on Radhika's
machine, but not otherwise?

But I think I know the answer: I'm guessing that when using Visual Studio to launch the debug
session, it was building its own copy in a default place (on `C:`), since the CMake support
in VS defaults to like `C:...\${workspaceHash}`. And otherwise on the CLI she was building
out of `D:\git\mesos` etc.

- Andrew Schwartzmeyer


On May 24, 2018, 7:52 p.m., Akash Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67313/
> -----------------------------------------------------------
> 
> (Updated May 24, 2018, 7:52 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `ROOT_DOCKER_DockerHealthStatusChange` was broken if the test ran
> in a drive other than `C:`, since only `C:` exists in the docker
> container with the default settings. The test was changed to hardcode
> the `C:` drive on Windows.
> 
> 
> Diffs
> -----
> 
>   src/tests/health_check_tests.cpp 7e8f86c903dfad73c2102eaf491fb2adcb7c11cf 
> 
> 
> Diff: https://reviews.apache.org/r/67313/diff/1/
> 
> 
> Testing
> -------
> 
> Waiting on CI to confirm that this fixes the issue there.
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message