mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Review Request 67310: Updated hashmap and LinkedHashMap to return vectors from values().
Date Fri, 25 May 2018 03:04:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67310/
-----------------------------------------------------------

Review request for mesos, Chun-Hung Hsiao and Gilbert Song.


Repository: mesos


Description
-------

std::list is prefered over std::vector for performance reasons, unless
frequent std::list advantageous operations are performed.


Diffs
-----

  3rdparty/stout/include/stout/hashmap.hpp 698fa0f3d198342dfc9743232992e648dbb1e6e6 
  3rdparty/stout/include/stout/linkedhashmap.hpp 33cc86ad132775c7b4f33fc78de63afc39d1afef

  3rdparty/stout/tests/linkedhashmap_tests.cpp 712752a60e23980652889dcecaeb1c20e233c94e 


Diff: https://reviews.apache.org/r/67310/diff/1/


Testing
-------


Thanks,

Benjamin Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message