mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Kordich via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.
Date Fri, 25 May 2018 02:13:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67066/
-----------------------------------------------------------

(Updated May 25, 2018, 2:13 a.m.)


Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, Eric Mumau,
Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.


Changes
-------

Updating patch for a new reviewbot run. Looks like downsizing the xz archive helped reviewboard
to accept the patch properly.


Bugs: MESOS-8064
    https://issues.apache.org/jira/browse/MESOS-8064


Repository: mesos


Description
-------

Modified the fetcher to use libarchive and added associated tests.


Diffs (updated)
-----

  src/launcher/fetcher.cpp 4cff7273fdc9e3897074da4da7dad02483086c2d 
  src/tests/fetcher_tests.cpp 95359ec84ed631bdd7b4fb5192e03f68cc57ed61 


Diff: https://reviews.apache.org/r/67066/diff/6/

Changes: https://reviews.apache.org/r/67066/diff/5-6/


Testing
-------

I've built on Windows with CMake and have run all tests, which all pass.
I've also built on Linux with both the autotools build and cmake build and have run all tests,
which all pass.


Thanks,

John Kordich


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message